Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend @typescript-eslint/recommended-type-checked instead of eslint-recommended and recommended #958

Merged
merged 2 commits into from
Oct 21, 2024

Conversation

Cyberbeni
Copy link
Contributor

https://typescript-eslint.io/users/configs/#recommended-type-checked

Both recommended and recommended-type-checked extend eslint-recommended, so eslint-recommended was already redundant. recommended-type-checked does not literally extend recommended but contains all the rules and more. Removed all the rules that are already set by this recommendation.

Fixed 1 new error about declaring the block async when there are no await calls inside.

@Cyberbeni Cyberbeni requested a review from a team as a code owner October 16, 2024 14:34
@ncalteen ncalteen self-assigned this Oct 21, 2024
Copy link
Collaborator

@ncalteen ncalteen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the simplification!

@ncalteen ncalteen merged commit 8bfd3a1 into actions:main Oct 21, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants