Skip to content
This repository has been archived by the owner on Mar 1, 2024. It is now read-only.

Fixed timeline pixelPerSecond #4

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

davidcommarmond
Copy link
Contributor

The pixel per second on the timeline was not accurate.

Changed it now

Begin values trying to get "gaps" between 2 tracks on the same nested timeline causing the import link to not work properly.

Fixed it by giving each block it's own absolute begin value ( instead of relative )
Blocks were using PNG icons.
I replaced them by the same material icons used in the footer block library for consistency.
@Fleker
Copy link
Contributor

Fleker commented Mar 31, 2023

Thanks for the PR. I see you sent a few PRs related to these changes last September. Is there anything new here?

@davidcommarmond
Copy link
Contributor Author

Hi @Fleker,
nothing new. These were the changes you asked to be reversed and send in a separate PR after the september ones would be approved ( Hence the 2 reversals of last year I'm pushing again here to fix the issues with pixel per seconds not being accurate ).

Thanks

@Fleker
Copy link
Contributor

Fleker commented Apr 3, 2023

It looks like the changes in this commit are identical to the ones made in #3

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants