[ADD] add 'OCA/repository' as category when sorting addons coming from OCA #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ping @marielejeune @qgroulard |
sbidoul
reviewed
Oct 26, 2024
| --oca-category Add category for third party addons coming from OCA. | ||
| The category is set as 'OCA/repository_name'. | ||
| If the repository can not be identified, | ||
| it falls into the default 'OCA' category. |
There was a problem hiding this comment.
It would be nice if we could have the grouping by OCA repo optional, as I personally prefer to have a single category for OCA.
sbidoul
reviewed
Oct 26, 2024
|
|
||
| if not repo_url: | ||
| return None | ||
| return search("OCA/.*", repo_url).group() |
There was a problem hiding this comment.
Suggested change
| return search("OCA/.*", repo_url).group() | |
| return re.search("OCA/.*", repo_url).group() |
When the function name is generic like that, I find it easier to have the module name here. I actually had to scroll up to understand what search was here.
Also take care that re.search can return None.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Description
Instead of having every OCA addon under the category '#OCA', it sorts by github repository (e.g. #OCA/account-payment)