Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] Updated the "Run the client" section and added an example using go run #17

Merged

Conversation

alexandregaldeano
Copy link
Contributor

No description provided.

@sbidoul
Copy link
Member

sbidoul commented Nov 28, 2024

What's wrong with the python client example?

@alexandregaldeano
Copy link
Contributor Author

When I first tried it, it didn't work. I thought something was wrong with the Python implementation, so I updated the README (so I don't forget later). It was a couple of days ago, and I now realized that the issues I first had had nothing to do with Python.

So, I can either add the Go example in complement to the Python example, or we can just close this PR. What's your preference?

Sorry about that :(

@sbidoul
Copy link
Member

sbidoul commented Nov 29, 2024

But the go example is just above, no?

@alexandregaldeano
Copy link
Contributor Author

Using the compiled binary yes, but not using the go run command, I don't know Go enough to know what are the actual implications of using one versus the other.

@sbidoul
Copy link
Member

sbidoul commented Nov 29, 2024

Ah I see. I don't know all the implications either but I guess adding a additional go run example is fine for easier testing.

@alexandregaldeano alexandregaldeano force-pushed the agaldeano/readme-client-run-command-update branch from 0aadb91 to a539969 Compare November 29, 2024 13:39
@alexandregaldeano
Copy link
Contributor Author

Ok, I put back the Python example. I also reorganized this section a little bit, what do you think?
image

@alexandregaldeano alexandregaldeano force-pushed the agaldeano/readme-client-run-command-update branch from a539969 to 1aa3bc3 Compare November 29, 2024 14:08
@alexandregaldeano alexandregaldeano changed the title [DOC] Fixed run command for the client still using Python instead of Go [DOC] Updated the "Run the client" section and added an example using go run Nov 29, 2024
@alexandregaldeano
Copy link
Contributor Author

I also renamed the commit and the PR

@sbidoul
Copy link
Member

sbidoul commented Nov 29, 2024

Nice, thanks!

@sbidoul sbidoul merged commit 9d6a013 into acsone:master Nov 29, 2024
@alexandregaldeano alexandregaldeano deleted the agaldeano/readme-client-run-command-update branch November 29, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants