Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(template-mcps): configure helm revision env #518

Merged
merged 1 commit into from
Nov 7, 2024
Merged

feat(template-mcps): configure helm revision env #518

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/datahub/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ description: A Helm chart for DataHub
type: application
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
version: 0.4.34
version: 0.4.35
# This is the version number of the application being deployed. This version number should be
# incremented each time you make changes to the application.
appVersion: 0.14.1
Expand Down
8 changes: 8 additions & 0 deletions charts/datahub/templates/datahub-upgrade/datahub-system-update-job.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,6 +142,10 @@ spec:
{{- end }}
- name: {{ $v.values_env }}
value: {{ $result | toJson | quote }}
{{- with $v.revision_env }}
- name: {{ . }}
value: '{"version":"{{ $.Chart.Version }}-{{ $.Release.Revision }}"}'
{{- end }}
{{- end }}
{{- with .Values.datahubSystemUpdate.extraEnvs }}
{{- toYaml . | nindent 12 }}
Expand Down Expand Up @@ -313,6 +317,10 @@ spec:
{{- end }}
- name: {{ $v.values_env }}
value: {{ $result | toJson | quote }}
{{- with $v.revision_env }}
- name: {{ . }}
value: '{"version":"{{ $.Chart.Version }}-{{ $.Release.Revision }}"}'
{{- end }}
{{- end }}
{{- with .Values.datahubSystemUpdate.extraEnvs }}
{{- toYaml . | nindent 12 }}
Expand Down
2 changes: 2 additions & 0 deletions charts/datahub/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -408,10 +408,12 @@ datahubSystemUpdate:
- "datahub.systemUpdate.datahubGC.timezone"
# Environment variable containing the json value for the template mcp
values_env: DATAHUB_GC_BOOTSTRAP_VALUES
revision_env: DATAHUB_GC_BOOTSTRAP_REVISION
# Base values for the template mcp
values:
ingestion:
name: datahub-gc
version: "0.14.1.7rc2"
schedule:
# overridden by global.datahub.timezone
timezone: "UTC"
Expand Down
Loading