-
Notifications
You must be signed in to change notification settings - Fork 241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(datahub-gms): Enable autoscaling via HPA #517
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
58773fa
feat(datahub-gms): Enable autoscaling via HPA
7onn 4d88b8f
trigger chart lint
7onn 1715d2b
trigger workflow
7onn 0ba87cc
Add missing datahub.image template for datahub-gms
7onn 779b0a9
Apply suggestions from code review
7onn 46681b4
Merge branch 'master' into 7onn/autoscale-gms
7onn File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,52 @@ | ||
{{- if .Values.hpa.enabled }} | ||
{{- $apiVersion := include "datahub-gms.hpa.apiVersion" . -}} | ||
apiVersion: {{ $apiVersion }} | ||
kind: HorizontalPodAutoscaler | ||
metadata: | ||
name: {{ include "datahub-gms.fullname" . }} | ||
labels: | ||
{{- include "datahub-gms.labels" . | nindent 4 }} | ||
{{- range $key, $val := .Values.extraLabels }} | ||
{{ $key }}: {{ $val | quote }} | ||
{{- end }} | ||
spec: | ||
{{- if and (.Values.global.strict_mode) (.Values.hpa.enabled) (.Values.global.datahub.managed_ingestion.enabled) (not .Values.global.datahub_standalone_consumers_enabled) }} | ||
{{- fail "\nHPA cannot be used in non standalone mode. Please enable standalone consumers if you wish to run multiple GMS instances and managed ingestion." }} | ||
{{- else }} | ||
scaleTargetRef: | ||
apiVersion: apps/v1 | ||
kind: Deployment | ||
name: {{ include "datahub-gms.fullname" . }} | ||
minReplicas: {{ .Values.hpa.minReplicas }} | ||
maxReplicas: {{ .Values.hpa.maxReplicas }} | ||
{{- with .Values.hpa.behavior }} | ||
behavior: | ||
{{- toYaml . | nindent 4 }} | ||
{{- end }} | ||
metrics: | ||
{{- with .Values.hpa.targetMemoryUtilizationPercentage }} | ||
- type: Resource | ||
resource: | ||
name: memory | ||
{{- if (eq $apiVersion "autoscaling/v2") }} | ||
target: | ||
type: Utilization | ||
averageUtilization: {{ . }} | ||
{{- else }} | ||
targetAverageUtilization: {{ . }} | ||
{{- end }} | ||
{{- end }} | ||
{{- with .Values.hpa.targetCPUUtilizationPercentage }} | ||
- type: Resource | ||
resource: | ||
name: cpu | ||
{{- if (eq $apiVersion "autoscaling/v2") }} | ||
target: | ||
type: Utilization | ||
averageUtilization: {{ . }} | ||
{{- else }} | ||
targetAverageUtilization: {{ . }} | ||
{{- end }} | ||
{{- end }} | ||
{{- end }} | ||
{{- end }} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the root chart has a similar template. I had to copy this so I could
helm template
from within the subchart folder.