Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Openshift compatibility #507

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

micheelengronne
Copy link

@micheelengronne micheelengronne commented Sep 26, 2024

Openshift needs to take over securityContext.

This PR creates a new value that disables security context handling by the chart.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

Openshift needs to take over securityContext.
@micheelengronne micheelengronne changed the title Openshift compatibility feat: Openshift compatibility Sep 26, 2024
@darnaut
Copy link
Contributor

darnaut commented Sep 26, 2024

Can you explain in more details why this is needed? It feels like this just needs a way to set securityContext to empty instead of adding a new option.

@micheelengronne
Copy link
Author

micheelengronne commented Sep 27, 2024

It is a trick to avoid falling into helm/helm#12879 I agree we should be able to do by nullifying the securityContext but in case of using this chart as a subchart it doesn't work. With that mechanism we are immune against this bug.

Copy link

This PR is stale. We will close it in 30 days if there is no comment or activity. If you want feedback but not able to get it on github please head to #contribute channel in slack at https://slack.datahubproject.io.

@github-actions github-actions bot added the stale label Oct 28, 2024
@micheelengronne
Copy link
Author

Hi @darnaut what do you think about this one ?

@github-actions github-actions bot removed the stale label Nov 1, 2024
Copy link

github-actions bot commented Dec 1, 2024

This PR is stale. We will close it in 30 days if there is no comment or activity. If you want feedback but not able to get it on github please head to #contribute channel in slack at https://slack.datahubproject.io.

@github-actions github-actions bot added the stale label Dec 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants