Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(image registry): allow configuring another image registry #479

Merged
merged 7 commits into from
Aug 28, 2024
Merged

feat(image registry): allow configuring another image registry #479

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
a6b8f95
feat(image registry): allow configuring another image registry like m…
DSchmidtDev Jun 19, 2024
c4d0b4a
feat(image registry): add documentation of schema registry override
DSchmidtDev Jun 19, 2024
09b919d
feat(image registry): fix versions
DSchmidtDev Jun 20, 2024
4b7c990
feat(image registry): fix image names
DSchmidtDev Aug 21, 2024
f6f10aa
feat(image registry): Use helm templates
DSchmidtDev Aug 27, 2024
0355179
feat(image registry): Reduce num of templates
DSchmidtDev Aug 28, 2024
98511c7
feat(image registry): Local registry config take precedence over glob…
DSchmidtDev Aug 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions charts/datahub/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,33 +4,33 @@ description: A Helm chart for DataHub
type: application
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
version: 0.4.22
version: 0.4.23
# This is the version number of the application being deployed. This version number should be
# incremented each time you make changes to the application.
appVersion: 0.14.0.2
dependencies:
- name: datahub-gms
version: 0.2.171
version: 0.2.172
repository: file://./subcharts/datahub-gms
condition: datahub-gms.enabled
- name: datahub-frontend
version: 0.2.158
version: 0.2.159
repository: file://./subcharts/datahub-frontend
condition: datahub-frontend.enabled
- name: datahub-mae-consumer
version: 0.2.160
version: 0.2.161
repository: file://./subcharts/datahub-mae-consumer
condition: global.datahub_standalone_consumers_enabled
- name: datahub-mce-consumer
version: 0.2.162
version: 0.2.163
repository: file://./subcharts/datahub-mce-consumer
condition: global.datahub_standalone_consumers_enabled
- name: datahub-ingestion-cron
version: 0.2.143
version: 0.2.144
repository: file://./subcharts/datahub-ingestion-cron
condition: datahub-ingestion-cron.enabled
- name: acryl-datahub-actions
version: 0.2.146
version: 0.2.147
repository: file://./subcharts/acryl-datahub-actions
condition: acryl-datahub-actions.enabled
maintainers:
Expand Down
21 changes: 14 additions & 7 deletions charts/datahub/README.md
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion charts/datahub/subcharts/acryl-datahub-actions/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ description: A Helm chart for Kubernetes
type: application
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
version: 0.2.146
version: 0.2.147
# This is the version number of the application being deployed. This version number should be
# incremented each time you make changes to the application.
appVersion: 0.0.11
1 change: 1 addition & 0 deletions charts/datahub/subcharts/acryl-datahub-actions/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ Current chart version is `0.0.3`
| image.args | list | `[]` | Override the image's args. Used to configure custom startup or shutdown behavior |
| image.command | list | `[]` | Override the image's command. Used to configure custom startup or shutdown behavior |
| image.pullPolicy | string | `"IfNotPresent"` | |
| image.registry | string | `"docker.io"` | Optional configuration of image registry to be used. |
| image.repository | string | `"acryldata/datahub-actions"` | |
| image.tag | string | `"v0.0.6"` | |
| imagePullSecrets | list | `[]` | |
Expand Down
4 changes: 2 additions & 2 deletions charts/datahub/subcharts/acryl-datahub-actions/templates/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ spec:
{{- end }}
{{- if .Values.priorityClassName }}
priorityClassName: "{{ .Values.priorityClassName }}"
{{- end }}
{{- end }}
initContainers:
{{- if .Values.extraInitContainers }}
{{- .Values.extraInitContainers | toYaml | nindent 6 }}
Expand All @@ -64,7 +64,7 @@ spec:
- name: {{ .Chart.Name }}
securityContext:
{{- toYaml .Values.securityContext | nindent 12 }}
image: "{{ .Values.image.repository }}:{{ .Values.image.tag }}"
image: {{ include "datahub.image" . }}
imagePullPolicy: {{ .Values.image.pullPolicy }}
ports:
- name: http
Expand Down
3 changes: 3 additions & 0 deletions charts/datahub/subcharts/acryl-datahub-actions/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
replicaCount: 1

image:
registry: docker.io
repository: acryldata/datahub-actions
tag: "v0.0.1"
pullPolicy: IfNotPresent
Expand Down Expand Up @@ -87,6 +88,8 @@ debug:
enabled: false

global:
imageRegistry: ""

kafka:
bootstrap:
server: "broker:9092"
Expand Down
2 changes: 1 addition & 1 deletion charts/datahub/subcharts/datahub-frontend/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ description: A Helm chart for Kubernetes
type: application
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
version: 0.2.158
version: 0.2.159
# This is the version number of the application being deployed. This version number should be
# incremented each time you make changes to the application.
appVersion: v0.13.1
Loading
Loading