Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(datahub-upgrade): allow specifying index settings as a map #465

Merged
merged 1 commit into from
May 21, 2024
Merged

feat(datahub-upgrade): allow specifying index settings as a map #465

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/datahub/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ description: A Helm chart for LinkedIn DataHub
type: application
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
version: 0.4.11
version: 0.4.12
# This is the version number of the application being deployed. This version number should be
# incremented each time you make changes to the application.
appVersion: 0.13.2
Expand Down
20 changes: 20 additions & 0 deletions charts/datahub/templates/datahub-upgrade/datahub-system-update-job.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,13 +109,23 @@ spec:
value: {{ . | quote }}
{{- end }}
{{- with .Values.global.elasticsearch.index.settingsOverrides }}
{{- if typeIs "map[string]interface {}" . }}
- name: ELASTICSEARCH_INDEX_BUILDER_SETTINGS_OVERRIDES
value: {{ toJson . | quote }}
{{- else }}
- name: ELASTICSEARCH_INDEX_BUILDER_SETTINGS_OVERRIDES
value: {{ . | quote }}
{{- end }}
{{- end }}
{{- with .Values.global.elasticsearch.index.entitySettingsOverrides }}
{{- if typeIs "map[string]interface {}" . }}
- name: ELASTICSEARCH_INDEX_BUILDER_ENTITY_SETTINGS_OVERRIDES
value: {{ toJson . | quote }}
{{- else }}
- name: ELASTICSEARCH_INDEX_BUILDER_ENTITY_SETTINGS_OVERRIDES
value: {{ . | quote }}
{{- end }}
{{- end }}
{{- with .Values.global.elasticsearch.index.refreshIntervalSeconds }}
- name: ELASTICSEARCH_INDEX_BUILDER_REFRESH_INTERVAL_SECONDS
value: {{ . | quote }}
Expand Down Expand Up @@ -261,13 +271,23 @@ spec:
value: {{ . | quote }}
{{- end }}
{{- with .Values.global.elasticsearch.index.settingsOverrides }}
{{- if typeIs "map[string]interface {}" . }}
- name: ELASTICSEARCH_INDEX_BUILDER_SETTINGS_OVERRIDES
value: {{ toJson . | quote }}
{{- else }}
- name: ELASTICSEARCH_INDEX_BUILDER_SETTINGS_OVERRIDES
value: {{ . | quote }}
{{- end }}
{{- end }}
{{- with .Values.global.elasticsearch.index.entitySettingsOverrides }}
{{- if typeIs "map[string]interface {}" . }}
- name: ELASTICSEARCH_INDEX_BUILDER_ENTITY_SETTINGS_OVERRIDES
value: {{ toJson . | quote }}
{{- else }}
- name: ELASTICSEARCH_INDEX_BUILDER_ENTITY_SETTINGS_OVERRIDES
value: {{ . | quote }}
{{- end }}
{{- end }}
{{- with .Values.global.elasticsearch.index.refreshIntervalSeconds }}
- name: ELASTICSEARCH_INDEX_BUILDER_REFRESH_INTERVAL_SECONDS
value: {{ . | quote }}
Expand Down
10 changes: 10 additions & 0 deletions charts/datahub/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -431,8 +431,18 @@ global:

## Index settings can be overridden for entity indices or other indices on an index by index basis
## Some index settings, such as # of shards, requires reindexing while others, i.e. replicas, do not
## The index settings options can be specified as a string or a map (which is converted to a string
## representation)
##
## Non-Entity indices do not require the prefix
# settingsOverrides: '{"graph_service_v1":{"number_of_shards":"5"},"system_metadata_service_v1":{"number_of_shards":"5"}}'
## or
# settingsOverrides:
# graph_service_v1:
# number_of_shards: '5'
# system_metadata_service_v1:
# number_of_shards: '6'
#
## Entity indices do not require the prefix or suffix
# entitySettingsOverrides: '{"dataset":{"number_of_shards":"10"}}'

Expand Down
Loading