feat: add custom image commands and arguments #408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 11, 2023 12:55
Add support for customizing an image's command or arguments. In our setup, we have some custom startup & shutdown behavior that need to run before the main process starts for things like enabling / disabling networking or injecting secrets. These cannot be configured with init containers since they need to run in the same place that the main process is going to run. If command / args are empty or not present, they will be excluded from helm, allowing the default command of the image to be used
david-leifker
approved these changes
Dec 11, 2023
|
Thanks! |
travis-cook-sfdc
pushed a commit
to travis-cook-sfdc/datahub-helm
that referenced
this pull request
Jan 4, 2024
Fix two issues with the custom command & args behavior added in acryldata#408: 1. Change custom command & args to use `toRawJson` instead of `toJson`. Previously, this resulted in special character would be escaped. For example, this value: ``` args: [ "source setup.sh && /datahub/datahub-gms/scripts/start.sh" ] ``` Would get rendered as: ``` args: [ "source setup.sh \u0026\u0026 /datahub/datahub-gms/scripts/start.sh" ] ``` Use `toRawJson` to force special values to not be escaped 2. Add custom command & args to all other containers that do not support it: - Datahub cleanup job - Datahub Nocode Migration Job - Datahub Restore Indices Job - Datahub System Update Job - Datahub Actions - Elastic Search Setup - Kafka Setup - Mysql Setup - Postgres setup
4 tasks
david-leifker
pushed a commit
that referenced
this pull request
Jan 4, 2024
* fix: fix custom command & args behavior Fix two issues with the custom command & args behavior added in #408: 1. Change custom command & args to use `toRawJson` instead of `toJson`. Previously, this resulted in special character would be escaped. For example, this value: ``` args: [ "source setup.sh && /datahub/datahub-gms/scripts/start.sh" ] ``` Would get rendered as: ``` args: [ "source setup.sh \u0026\u0026 /datahub/datahub-gms/scripts/start.sh" ] ``` Use `toRawJson` to force special values to not be escaped 2. Add custom command & args to all other containers that do not support it: - Datahub cleanup job - Datahub Nocode Migration Job - Datahub Restore Indices Job - Datahub System Update Job - Datahub Actions - Elastic Search Setup - Kafka Setup - Mysql Setup - Postgres setup * fix lint issues --------- Co-authored-by: Travis Cook <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for customizing an image's command or arguments. In our setup, we have some custom startup & shutdown behavior that need to run before the main process starts for things like enabling / disabling networking or injecting secrets. These cannot be configured with init containers since they need to run in the same place that the main process is going to run. If command / args are empty or not present, they will be excluded from helm, allowing the default command of the image to be used
Checklist