feat: add monitoring.portName in values.yaml
#407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for customizing the `portName` for monitoring. It is currently hardcoded to `jmx`. In our setup, the prometheus scraper is looking for ports that are called `prometheus`. This change allows this value to be customized to any value that is needed for a specific environment. If no value is provided, it remains `jmx`.
| @@ -18,105 +18,106 @@ helm install datahub datahub/datahub --values <<path-to-values-file>> | |||
|
|
|||
| ## Chart Values | |||
|
|
|||
| | Key | Type | Default | Description | | |||
There was a problem hiding this comment.
Sorry for the large diff here. My IDE lined up the pipes on the table so that it's more readable in a text editor. I opted to leave this in but can undo if that's preferable
| | global.datahub_analytics_enabled | boolean | true | Enable datahub usage analytics | | ||
| | global.datahub.appVersion | string | `"1.0"` | App version for annotation | | ||
| | global.datahub.gms.port | string | `"8080"` | Port of GMS service | | ||
| | global.datahub.monitoring.portName | string | `jmx` | Name of Kube port for monitoring | |
There was a problem hiding this comment.
this line is new
david-leifker
approved these changes
Dec 11, 2023
|
LGTM! Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for customizing the
portNamefor monitoring. It is currently hardcoded tojmx. In our setup, the prometheus scraper is looking for ports that are calledprometheus. This change allows this value to be customized to any value that is needed for a specific environment. If no value is provided, it remainsjmx.Checklist