fix(ingestion-cron): remove duplicate shell command in cron chart #391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Presence of square brackets create incorrect command when passed to template. This commit removes square brackets and now the chart should be installable. Verified by helm template datahub-ingestion-cron
maggiehays
added
the
hacktoberfest-accepted
|
Thanks! Merged w/o chart increment since it was a commented line. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes issue mentioned at #389 .The duplicate shell command is removed from values.yaml since it is already present in cron.yaml template. Thanks @jimsmith for reporting and figuring out the root cause.
Checklist