Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability for edit user_name_claim and regex #388

Merged

Conversation

gschuurman
Copy link
Contributor

Fix issue where identity token does not contain an email addres. This can be the case for some azure only tenants where no email is configured on the domain.

Might fix: datahub-project/datahub#8965

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

Fix issue where identity token does not contain an email addres. This
can be the case for some azure only tenants where no email is configured
on the domain.
@gschuurman gschuurman force-pushed the feature/oidc_user_name_claim branch 2 times, most recently from 8361fca to a87129a Compare October 25, 2023 14:27
@maggiehays maggiehays added the hacktoberfest-accepted Acceptance for hacktoberfest https://hacktoberfest.com/participation/ label Oct 26, 2023
Copy link

This PR is stale. We will close it in 30 days if there is no comment or activity. If you want feedback but not able to get it on github please head to #contribute channel in slack at https://slack.datahubproject.io.

@github-actions github-actions bot added the stale label Nov 26, 2023
@RyanHolstien RyanHolstien merged commit b3f33cf into acryldata:master Nov 27, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted Acceptance for hacktoberfest https://hacktoberfest.com/participation/ stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issues with Azure OIDC
3 participants