Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fiz(hazelcast): replace all invalid chars #386

Conversation

sgomezvillamor
Copy link
Contributor

@sgomezvillamor sgomezvillamor commented Oct 23, 2023

This is fixing the following error where _ character is not being replaced and still being invalid.


Error: UPGRADE FAILED: failed to create resource: Service "pre-0-11-0_2-0-0-hazelcast-svc" is invalid: metadata.name: Invalid value: "pre-0-11-0_2-0-0-hazelcast-svc": a DNS-1035 label must consist of lower case alphanumeric characters or '-', start with an alphabetic character, and end with an alphanumeric character (e.g. 'my-name',  or 'abc-123', regex used for validation is '[a-z]([-a-z0-9]*[a-z0-9])?')

The fix replaces all invalid chars, that is [^-a-z0-9]+

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

@pedro93 pedro93 requested a review from david-leifker October 23, 2023 10:15
@david-leifker
Copy link
Contributor

Thanks!

@david-leifker david-leifker merged commit ee2bc53 into acryldata:master Oct 23, 2023
1 check passed
@sgomezvillamor sgomezvillamor deleted the fix-hazelcast-replace-invalid-chars branch October 23, 2023 14:00
@maggiehays maggiehays added the hacktoberfest-accepted Acceptance for hacktoberfest https://hacktoberfest.com/participation/ label Oct 26, 2023
@sgomezvillamor sgomezvillamor mentioned this pull request Mar 21, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted Acceptance for hacktoberfest https://hacktoberfest.com/participation/
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants