Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(sql): allow providing username from secret for sql setup jobs #380

Merged
merged 1 commit into from
Nov 16, 2023
Merged

feat(sql): allow providing username from secret for sql setup jobs #380

merged 1 commit into from
Nov 16, 2023

Conversation

Gerrit-K
Copy link
Contributor

This adds the functionality from #291 to the MySQL and PostgreSQL setup jobs

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

@maggiehays maggiehays added the hacktoberfest-accepted Acceptance for hacktoberfest https://hacktoberfest.com/participation/ label Oct 26, 2023
@Gerrit-K Gerrit-K force-pushed the sql-datasource-username-secret branch 2 times, most recently from 2a38a0f to 82fdf65 Compare November 14, 2023 07:33
@Gerrit-K Gerrit-K force-pushed the sql-datasource-username-secret branch from 82fdf65 to 934f35f Compare November 16, 2023 08:02
@Gerrit-K
Copy link
Contributor Author

Hey @RyanHolstien, thanks for approving! I've updated the branch and Chart.yaml version again, so it should hopefully now be ready to be merged :)

@RyanHolstien RyanHolstien merged commit 6311fce into acryldata:master Nov 16, 2023
1 check passed
@Gerrit-K Gerrit-K deleted the sql-datasource-username-secret branch December 6, 2023 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RyanHolstien RyanHolstien RyanHolstien approved these changes

Assignees
No one assigned
Labels
hacktoberfest-accepted Acceptance for hacktoberfest https://hacktoberfest.com/participation/
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Gerrit-K @RyanHolstien @maggiehays