-
Notifications
You must be signed in to change notification settings - Fork 241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(datahub-upgrade): adding concurrency policy for the cronjobs #376
Conversation
I though you might have missed it here but it was taken care already.
|
@upendra-vedullapalli I can update. Let me take a look. |
@upendra-vedullapalli I see that there is no dependency chart in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please a take a look at my comments.
charts/datahub/templates/datahub-upgrade/datahub-restore-indices-job-template.yml
Outdated
Show resolved
Hide resolved
charts/datahub/templates/datahub-upgrade/datahub-cleanup-job-template.yml
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Probably you need a maintainers approval for merge 🤞
How do I get that privilege? |
Thanks for the contribution! 😄 |
Context
By default, the concurrency policy for the cronjobs is
Allow
. In a few deployment strategies, concurrencyPolicy is defaulted toForbid
. In those scenarios, the upstream chart should have the option for it to be set.This PR will help in accomplishing that.
Checklist