fix(neo4j): enable APOC plugin #353
Conversation
|
This PR is stale. We will close it in 30 days if there is no comment or activity. If you want feedback but not able to get it on github please head to #contribute channel in slack at https://slack.datahubproject.io. |
|
Even though adopting APOC algorithms for Neo4j queries is not of highest priority at this moment in the DataHub code base, having APOC enabled already has no noticeable impact on the systems and will make future adoption of APOC algorithms easier. So I kindly advise merging this PR 😊 |
…apoc-plugin # Conflicts: # charts/prerequisites/values.yaml
|
Adjusted the introduction of the APOC env var after the Neo4j reference chart has been updated. |
|
Reference to example how an env var is added based on the new chart structure: |
|
Hiya @lix-mms 😄 Thanks for the contribution, do you mind updating the chart version on this PR? |
|
@RyanHolstien My pleasure to contribute! I updated the version accordingly. 😊 |
|
Ah sorry! I should have been more specific, since this is a change to the prerequisites chart it has to be an update to the datahub-prerequisites Chart.yaml. |
lix-mms
force-pushed
the
fix/neo4j/enable-apoc-plugin
branch
from
5ae518b to
8eaa5f6
Compare
|
@RyanHolstien Oh... right! Thanks for the catch! Fixed it accordingly 😄 |
|
Thank you! 😄 |
* fix(neo4j): enable APOC plugin * config: fix format of adding env var for neo4j * config: update prerequisites chart version to 0.1.2
Prerequisite change for datahub-project/datahub#8687
Checklist
Links to related issues (if applicable)Tests for the changes have been added/updated (if applicable)Docs related to the changes have been added/updated (if applicable)