Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(config): Change the default service type to ClusterIP #352

Closed
wants to merge 2 commits into from

Conversation

MateusCastello
Copy link

*fix(config): Change the default service type to ClusterIP

There is no need for the front-end and datahub-gms to deafault this services as LoadBalancers, as this configuration opens an external public IP on Cloud Environments, leading to potential security breaches on developing and quick-start scenarios.

@github-actions
Copy link

This PR is stale. We will close it in 30 days if there is no comment or activity. If you want feedback but not able to get it on github please head to #contribute channel in slack at https://slack.datahubproject.io.

@github-actions github-actions bot added the stale label Sep 16, 2023
@pjaak
Copy link

pjaak commented Oct 4, 2023

Hi,

We ran into a similar issue recently where we specified an ingress resource that was internal, so we thought it was deployed internally, however, the default sub-chart values had also created a public-facing AWS load balancer. The fact that these values weren't exposed in the parent chart values means it is easy to miss. Would be good to get this reviewed by someone. I was going to create a PR with the same changes until I saw this one. LGTM

Thanks

@LiamStorkey
Copy link

This LGTM - I recently had a similar security alert go off for this default sub-chart public load balancer.

@github-actions github-actions bot removed the stale label Oct 5, 2023
@RyanHolstien
Copy link
Contributor

Hiya @MateusCastello ! Would you be willing to update the chart versions on this PR? Unfortunately you made this PR directly from your master branch instead of creating a branch so it's not letting me update the chart versions.

Copy link

github-actions bot commented Nov 5, 2023

This PR is stale. We will close it in 30 days if there is no comment or activity. If you want feedback but not able to get it on github please head to #contribute channel in slack at https://slack.datahubproject.io.

@github-actions github-actions bot added the stale label Nov 5, 2023
Copy link

github-actions bot commented Dec 5, 2023

Closing stale PR.

@github-actions github-actions bot closed this Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants