Skip to content

Commit

Permalink
feat(kafka): enable kafka message size options
Browse files Browse the repository at this point in the history
  • Loading branch information
david-leifker committed Oct 18, 2023
1 parent de72e07 commit fcde3cf
Show file tree
Hide file tree
Showing 12 changed files with 72 additions and 11 deletions.
8 changes: 4 additions & 4 deletions charts/datahub/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,25 +4,25 @@ description: A Helm chart for LinkedIn DataHub
type: application
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
version: 0.2.181
version: 0.2.182
# This is the version number of the application being deployed. This version number should be
# incremented each time you make changes to the application.
appVersion: 0.10.5
dependencies:
- name: datahub-gms
version: 0.2.150
version: 0.2.151
repository: file://./subcharts/datahub-gms
condition: datahub-gms.enabled
- name: datahub-frontend
version: 0.2.139
repository: file://./subcharts/datahub-frontend
condition: datahub-frontend.enabled
- name: datahub-mae-consumer
version: 0.2.146
version: 0.2.147
repository: file://./subcharts/datahub-mae-consumer
condition: global.datahub_standalone_consumers_enabled
- name: datahub-mce-consumer
version: 0.2.149
version: 0.2.150
repository: file://./subcharts/datahub-mce-consumer
condition: global.datahub_standalone_consumers_enabled
- name: datahub-ingestion-cron
Expand Down
2 changes: 1 addition & 1 deletion charts/datahub/subcharts/datahub-gms/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ description: A Helm chart for LinkedIn DataHub's datahub-gms component
type: application
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
version: 0.2.150
version: 0.2.151
# This is the version number of the application being deployed. This version number should be
# incremented each time you make changes to the application.
appVersion: v0.10.0
12 changes: 12 additions & 0 deletions charts/datahub/subcharts/datahub-gms/templates/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -165,6 +165,18 @@ spec:
value: "{{ .Values.global.sql.datasource.driver }}"
- name: KAFKA_BOOTSTRAP_SERVER
value: "{{ .Values.global.kafka.bootstrap.server }}"
{{- with .Values.global.kafka.producer.compressionType }}
- name: KAFKA_PRODUCER_COMPRESSION_TYPE
value: "{{ . }}"
{{- end }}
{{- with .Values.global.kafka.producer.maxRequestSize }}
- name: KAFKA_PRODUCER_MAX_REQUEST_SIZE
value: "{{ . }}"
{{- end }}
{{- with .Values.global.kafka.consumer.maxPartitionFetchBytes }}
- name: KAFKA_CONSUMER_MAX_PARTITION_FETCH_BYTES
value: "{{ . }}"
{{- end }}
{{- if eq .Values.global.kafka.schemaregistry.type "INTERNAL" }}
- name: KAFKA_SCHEMAREGISTRY_URL
value: {{ printf "http://localhost:%s/schema-registry/api/" .Values.global.datahub.gms.port }}
Expand Down
6 changes: 6 additions & 0 deletions charts/datahub/subcharts/datahub-gms/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -160,6 +160,12 @@ global:
server: "broker:9092"
schemaregistry:
url: "http://schema-registry:8081"
## Kafka producer and consumer settings
#producer:
# compressionType: snappy
# maxRequestSize: 5242880
#consumer:
# maxPartitionFetchBytes: 5242880

neo4j:
host: "neo4j:7474"
Expand Down
2 changes: 1 addition & 1 deletion charts/datahub/subcharts/datahub-mae-consumer/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ description: A Helm chart for Kubernetes
type: application
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
version: 0.2.146
version: 0.2.147
# This is the version number of the application being deployed. This version number should be
# incremented each time you make changes to the application.
appVersion: v0.10.0
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,18 @@ spec:
value: "{{ .Values.global.datahub.gms.port }}"
- name: KAFKA_BOOTSTRAP_SERVER
value: "{{ .Values.global.kafka.bootstrap.server }}"
{{- with .Values.global.kafka.producer.compressionType }}
- name: KAFKA_PRODUCER_COMPRESSION_TYPE
value: "{{ . }}"
{{- end }}
{{- with .Values.global.kafka.producer.maxRequestSize }}
- name: KAFKA_PRODUCER_MAX_REQUEST_SIZE
value: "{{ . }}"
{{- end }}
{{- with .Values.global.kafka.consumer.maxPartitionFetchBytes }}
- name: KAFKA_CONSUMER_MAX_PARTITION_FETCH_BYTES
value: "{{ . }}"
{{- end }}
{{- if eq .Values.global.kafka.schemaregistry.type "INTERNAL" }}
- name: KAFKA_SCHEMAREGISTRY_URL
value: {{ printf "http://%s-%s:%s/schema-registry/api/" .Release.Name "datahub-gms" .Values.global.datahub.gms.port }}
Expand Down
6 changes: 6 additions & 0 deletions charts/datahub/subcharts/datahub-mae-consumer/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -180,6 +180,12 @@ global:
server: "broker:9092"
schemaregistry:
url: "http://schema-registry:8081"
## Kafka producer and consumer settings
#producer:
# compressionType: snappy
# maxRequestSize: 5242880
#consumer:
# maxPartitionFetchBytes: 5242880

neo4j:
host: "neo4j:7474"
Expand Down
2 changes: 1 addition & 1 deletion charts/datahub/subcharts/datahub-mce-consumer/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ description: A Helm chart for Kubernetes
type: application
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
version: 0.2.149
version: 0.2.150
# This is the version number of the application being deployed. This version number should be
# incremented each time you make changes to the application.
appVersion: v0.10.0
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,18 @@ spec:
value: "true"
- name: KAFKA_BOOTSTRAP_SERVER
value: "{{ .Values.global.kafka.bootstrap.server }}"
{{- with .Values.global.kafka.producer.compressionType }}
- name: KAFKA_PRODUCER_COMPRESSION_TYPE
value: "{{ . }}"
{{- end }}
{{- with .Values.global.kafka.producer.maxRequestSize }}
- name: KAFKA_PRODUCER_MAX_REQUEST_SIZE
value: "{{ . }}"
{{- end }}
{{- with .Values.global.kafka.consumer.maxPartitionFetchBytes }}
- name: KAFKA_CONSUMER_MAX_PARTITION_FETCH_BYTES
value: "{{ . }}"
{{- end }}
{{- if eq .Values.global.kafka.schemaregistry.type "INTERNAL" }}
- name: KAFKA_SCHEMAREGISTRY_URL
value: {{ printf "http://%s-%s:%s/schema-registry/api/" .Release.Name "datahub-gms" .Values.global.datahub.gms.port }}
Expand Down
6 changes: 6 additions & 0 deletions charts/datahub/subcharts/datahub-mce-consumer/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -176,6 +176,12 @@ global:
server: "broker:9092"
schemaregistry:
url: "http://schema-registry:8081"
# Kafka producer and consumer settings
#producer:
# compressionType: snappy
# maxRequestSize: 5242880
#consumer:
# maxPartitionFetchBytes: 5242880

datahub:
version: head
Expand Down
9 changes: 8 additions & 1 deletion charts/datahub/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -497,6 +497,13 @@ global:
# region: us-east-1
# registry: datahub

## Kafka producer and consumer settings
producer:
compressionType: snappy
maxRequestSize: 5242880
consumer:
maxPartitionFetchBytes: 5242880

neo4j:
host: "prerequisites-neo4j-community:7474"
uri: "bolt://prerequisites-neo4j-community"
Expand Down Expand Up @@ -554,7 +561,7 @@ global:
# value: password

datahub:
version: v0.10.5
version: v0.11.0
gms:
port: "8080"
nodePort: "30001"
Expand Down
6 changes: 3 additions & 3 deletions charts/prerequisites/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -15,16 +15,16 @@ elasticsearch:
clusterHealthCheckParams: "wait_for_status=yellow&timeout=1s"

# # Shrink default JVM heap.
esJavaOpts: "-Xmx384m -Xms384m"
esJavaOpts: "-Xmx512m -Xms512m"

# # Allocate smaller chunks of memory per pod.
resources:
requests:
cpu: "100m"
memory: "768M"
memory: "1024M"
limits:
cpu: "1000m"
memory: "768M"
memory: "1024M"

# # Request smaller persistent volumes.
# volumeClaimTemplate:
Expand Down

0 comments on commit fcde3cf

Please sign in to comment.