Skip to content

Commit

Permalink
fix: Remove unused config
Browse files Browse the repository at this point in the history 
The code which used the `exporters.jmx` config was removed in #181.
  • Loading branch information
@daha
daha committed May 14, 2024
1 parent 2cc4fae commit c18ca8e
Show file tree
Hide file tree
Showing 11 changed files with 9 additions and 140 deletions.
10 changes: 5 additions & 5 deletions charts/datahub/Chart.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ description: A Helm chart for LinkedIn DataHub
type: application
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
version: 0.4.10
version: 0.4.11
# This is the version number of the application being deployed. This version number should be
# incremented each time you make changes to the application.
appVersion: 0.13.2
Expand All @@ -14,23 +14,23 @@ dependencies:
repository: file://./subcharts/datahub-gms
condition: datahub-gms.enabled
- name: datahub-frontend
version: 0.2.157
version: 0.2.158
repository: file://./subcharts/datahub-frontend
condition: datahub-frontend.enabled
- name: datahub-mae-consumer
version: 0.2.158
version: 0.2.159
repository: file://./subcharts/datahub-mae-consumer
condition: global.datahub_standalone_consumers_enabled
- name: datahub-mce-consumer
version: 0.2.160
version: 0.2.161
repository: file://./subcharts/datahub-mce-consumer
condition: global.datahub_standalone_consumers_enabled
- name: datahub-ingestion-cron
version: 0.2.143
repository: file://./subcharts/datahub-ingestion-cron
condition: datahub-ingestion-cron.enabled
- name: acryl-datahub-actions
version: 0.2.144
version: 0.2.145
repository: file://./subcharts/acryl-datahub-actions
condition: acryl-datahub-actions.enabled
maintainers:
Expand Down
1 change: 0 additions & 1 deletion charts/datahub/subcharts/acryl-datahub-actions/README.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ Current chart version is `0.0.3`
| Key | Type | Default | Description |
|-----------------------------------------------------------------------------|---------------------------------------------------------------------------------------------------|-------------------------------|----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
| affinity | object | `{}` | |
| exporters.jmx.enabled | boolean | false | |
| extraLabels | object | `{}` | Extra labels for deployment configuration |
| extraEnvs | Extra [environment variables][] which will be appended to the `env:` definition for the container | `[]` |
| extraSidecars | list | `[]` | Add additional sidecar containers to the deployment pod(s) |
Expand Down
2 changes: 1 addition & 1 deletion charts/datahub/subcharts/datahub-frontend/Chart.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ description: A Helm chart for Kubernetes
type: application
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
version: 0.2.157
version: 0.2.158
# This is the version number of the application being deployed. This version number should be
# incremented each time you make changes to the application.
appVersion: v0.13.1
3 changes: 1 addition & 2 deletions charts/datahub/subcharts/datahub-frontend/README.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ Current chart version is `0.2.0`
| affinity | object | `{}` | |
| datahub.play.mem.buffer.size | string | `"10MB"` | |
| existingGmsSecret | object | {} | Reference to GMS secret if already exists |
| exporters.jmx.enabled | boolean | false | |
| extraLabels | object | `{}` | Extra labels for deployment configuration |
| extraEnvs | Extra [environment variables][] which will be appended to the `env:` definition for the container | `[]` |
| extraSidecars | list | `[]` | Add additional sidecar containers to the deployment pod(s) |
Expand All @@ -21,7 +20,7 @@ Current chart version is `0.2.0`
| fullnameOverride | string | `"datahub-frontend"` | |
| global.datahub_analytics_enabled | boolean | true | |
| global.datahub.gms.port | string | `"8080"` | |
| global.datahub.frontend.validateSignUpEmail | boolean | true | Enforces user sign up through invite link to use a valid email. |
| global.datahub.frontend.validateSignUpEmail | boolean | true | Enforces user sign up through invite link to use a valid email. |
| image.args | list | `[]` | Override the image's args. Used to configure custom startup or shutdown behavior |
| image.command | list | `[]` | Override the image's command. Used to configure custom startup or shutdown behavior |
| image.pullPolicy | string | `"IfNotPresent"` | |
Expand Down
43 changes: 0 additions & 43 deletions charts/datahub/subcharts/datahub-frontend/values.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -163,49 +163,6 @@ affinity: {}
env:
JMXPORT: 1099

exporters:
jmx:
enabled: false
# image:
# repository: bitnami/jmx-exporter
# tag: 0.15.0
# pullPolicy: IfNotPresent
# config:
# lowercaseOutputName: true
# lowercaseOutputLabelNames: true
# rules:
# - pattern: ".*"
# startDelaySeconds: 30
# env: {}
# resources: {}
# path: /metrics
# ports:
# jmxxp:
# containerPort: 5556
# protocol: TCP
# livenessProbe:
# httpGet:
# path: /metrics
# port: jmxxp
# initialDelaySeconds: 30
# periodSeconds: 15
# timeoutSeconds: 60
# failureThreshold: 8
# successThreshold: 1
# readinessProbe:
# httpGet:
# path: /metrics
# port: jmxxp
# initialDelaySeconds: 30
# periodSeconds: 15
# timeoutSeconds: 60
# failureThreshold: 8
# successThreshold: 1
# serviceMonitor:
# interval: 30s
# scrapeTimeout: 30s
# scheme: http

livenessProbe:
initialDelaySeconds: 60
periodSeconds: 30
Expand Down
2 changes: 1 addition & 1 deletion charts/datahub/subcharts/datahub-mae-consumer/Chart.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ description: A Helm chart for Kubernetes
type: application
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
version: 0.2.158
version: 0.2.159
# This is the version number of the application being deployed. This version number should be
# incremented each time you make changes to the application.
appVersion: v0.13.1
1 change: 0 additions & 1 deletion charts/datahub/subcharts/datahub-mae-consumer/README.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ Current chart version is `0.2.0`
| Key | Type | Default | Description |
|-----------------------------------------------------------------------------|---------------------------------------------------------------------------------------------------|-----------------------------------|----------------------------------------------------------------------------------------------------------------------------------------------------------------------|
| affinity | object | `{}` | |
| exporters.jmx.enabled | boolean | false | |
| extraLabels | object | `{}` | Extra labels for deployment configuration |
| extraEnvs | Extra [environment variables][] which will be appended to the `env:` definition for the container | `[]` |
| extraSidecars | list | `[]` | Add additional sidecar containers to the deployment pod(s) |
Expand Down
42 changes: 0 additions & 42 deletions charts/datahub/subcharts/datahub-mae-consumer/values.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -122,48 +122,6 @@ affinity: {}
env:
JMXPORT: 1099

exporters:
jmx:
enabled: false
# image:
# repository: bitnami/jmx-exporter
# tag: 0.15.0
# pullPolicy: IfNotPresent
# config:
# lowercaseOutputName: true
# rules:
# - pattern: ".*"
# startDelaySeconds: 30
# env: {}
# resources: {}
# path: /metrics
# ports:
# jmxxp:
# containerPort: 5556
# protocol: TCP
# livenessProbe:
# httpGet:
# path: /metrics
# port: jmxxp
# initialDelaySeconds: 30
# periodSeconds: 15
# timeoutSeconds: 60
# failureThreshold: 8
# successThreshold: 1
# readinessProbe:
# httpGet:
# path: /metrics
# port: jmxxp
# initialDelaySeconds: 30
# periodSeconds: 15
# timeoutSeconds: 60
# failureThreshold: 8
# successThreshold: 1
# serviceMonitor:
# interval: 30s
# scrapeTimeout: 30s
# scheme: http

livenessProbe:
initialDelaySeconds: 60
periodSeconds: 30
Expand Down
2 changes: 1 addition & 1 deletion charts/datahub/subcharts/datahub-mce-consumer/Chart.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ description: A Helm chart for Kubernetes
type: application
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
version: 0.2.160
version: 0.2.161
# This is the version number of the application being deployed. This version number should be
# incremented each time you make changes to the application.
appVersion: v0.13.1
Loading

0 comments on commit c18ca8e

Please sign in to comment.