Skip to content

Commit

Permalink
feat(image registry): Local registry config take precedence over glob…
Browse files Browse the repository at this point in the history 
…al config
  • Loading branch information
@DSchmidtDev
DSchmidtDev committed Aug 28, 2024
1 parent 0355179 commit a75c444
Show file tree
Hide file tree
Showing 15 changed files with 21 additions and 34 deletions.
14 changes: 7 additions & 7 deletions charts/datahub/README.md
View file

Large diffs are not rendered by default.

3 changes: 1 addition & 2 deletions charts/datahub/subcharts/acryl-datahub-actions/README.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ Current chart version is `0.0.3`

| Key | Type | Default | Description |
|-----------------------------------------------------------------------------|---------------------------------------------------------------------------------------------------|-------------------------------|----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
| affinity | object | `{}` | |
| extraLabels | object | `{}` | Extra labels for deployment configuration |
| extraEnvs | Extra [environment variables][] which will be appended to the `env:` definition for the container | `[]` |
| extraSidecars | list | `[]` | Add additional sidecar containers to the deployment pod(s) |
Expand All @@ -19,7 +18,7 @@ Current chart version is `0.0.3`
| image.args | list | `[]` | Override the image's args. Used to configure custom startup or shutdown behavior |
| image.command | list | `[]` | Override the image's command. Used to configure custom startup or shutdown behavior |
| image.pullPolicy | string | `"IfNotPresent"` | |
| image.registry | string | `"docker.io"` | Optional configuration of image registry to be used. |
| image.registry | string | `` | Image registry override to be used by the job. |
| image.repository | string | `"acryldata/datahub-actions"` | |
| image.tag | string | `"v0.0.6"` | |
| imagePullSecrets | list | `[]` | |
Expand Down
3 changes: 1 addition & 2 deletions charts/datahub/subcharts/acryl-datahub-actions/values.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
replicaCount: 1

image:
registry: docker.io
repository: acryldata/datahub-actions
tag: "v0.0.1"
pullPolicy: IfNotPresent
Expand Down Expand Up @@ -88,7 +87,7 @@ debug:
enabled: false

global:
imageRegistry: ""
imageRegistry: "docker.io"

kafka:
bootstrap:
Expand Down
2 changes: 1 addition & 1 deletion charts/datahub/subcharts/datahub-frontend/README.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ Current chart version is `0.2.0`
| image.args | list | `[]` | Override the image's args. Used to configure custom startup or shutdown behavior |
| image.command | list | `[]` | Override the image's command. Used to configure custom startup or shutdown behavior |
| image.pullPolicy | string | `"IfNotPresent"` | |
| image.registry | string | `"docker.io"` | Optional configuration of image registry to be used. |
| image.registry | string | `` | Image registry override to be used by the job. |
| image.repository | string | `"acryldata/datahub-frontend-react"` | |
| image.tag | string | `"head"` | |
| imagePullSecrets | list | `[]` | |
Expand Down
3 changes: 1 addition & 2 deletions charts/datahub/subcharts/datahub-frontend/values.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ replicaCount: 1
revisionHistoryLimit: 10

image:
registry: docker.io
repository: acryldata/datahub-frontend-react
tag:
pullPolicy: IfNotPresent
Expand Down Expand Up @@ -181,7 +180,7 @@ datahub:
buffer:
size: "10MB"
global:
imageRegistry: ""
imageRegistry: "docker.io"

datahub_analytics_enabled: true

Expand Down
2 changes: 1 addition & 1 deletion charts/datahub/subcharts/datahub-gms/README.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ Current chart version is `0.2.0`
| image.args | list | `[]` | Override the image's args. Used to configure custom startup or shutdown behavior |
| image.command | list | `[]` | Override the image's command. Used to configure custom startup or shutdown behavior |
| image.pullPolicy | string | `"IfNotPresent"` | |
| image.registry | string | `"docker.io"` | Optional configuration of image registry to be used. |
| image.registry | string | `` | Image registry override to be used by the job. |
| image.repository | string | `"acryldata/datahub-gms"` | |
| image.tag | string | `"head"` | |
| imagePullSecrets | list | `[]` | |
Expand Down
3 changes: 1 addition & 2 deletions charts/datahub/subcharts/datahub-gms/values.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ replicaCount: 1
revisionHistoryLimit: 10

image:
registry: docker.io
repository: acryldata/datahub-gms
pullPolicy: IfNotPresent
tag:
Expand Down Expand Up @@ -142,7 +141,7 @@ readinessProbe:
#This section is useful if we are installing this chart separately for testing
# helm install datahub-gms datahub-gms/
global:
imageRegistry: ""
imageRegistry: "docker.io"

datahub_analytics_enabled: true
graph_service_impl: elasticsearch
Expand Down
2 changes: 1 addition & 1 deletion charts/datahub/subcharts/datahub-ingestion-cron/README.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ A Helm chart for datahub's metadata-ingestion framework with kerberos authentica
| Key | Type | Default | Description |
|----------------------------------|---------|------------------------------------------------------------------------------|-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
| image.pullPolicy | string | `"IfNotPresent"` | Image pull policy |
| image.registry | string | `"docker.io"` | Optional configuration of image registry to be used. |
| image.registry | string | `` | Image registry override to be used by the job. |
| image.repository | string | `"acryldata/datahub-ingestion"` | DataHub Ingestion image repository |
| image.tag | string | `"head"` | DataHub Ingestion image tag |
| imagePullSecrets | array | `[]` (does not add image pull secrets to deployed pods) | Docker registry secret names as an array |
Expand Down
3 changes: 1 addition & 2 deletions charts/datahub/subcharts/datahub-ingestion-cron/values.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
# Declare variables to be passed into your templates.

image:
registry: docker.io
repository: acryldata/datahub-ingestion
tag:
pullPolicy: IfNotPresent
Expand Down Expand Up @@ -143,7 +142,7 @@ crons: {}
#suspend: true

global:
imageRegistry: ""
imageRegistry: "docker.io"

datahub:
version: head
Loading

0 comments on commit a75c444

Please sign in to comment.