Skip to content

Commit

Permalink
Fix OIDC username claim not overridable for azure
Browse files Browse the repository at this point in the history
Fix Issue #414 where
only google OIDC Username claim and regexp were overridable. This was
incorrect, and should have never been the case, this is especially
important for azure since some Entra ID deployments do not specify email
addresses in the OIDC token.
  • Loading branch information
Glenn Schuurman committed Dec 19, 2023
1 parent ceb3a26 commit 8a7c3cf
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 7 deletions.
4 changes: 2 additions & 2 deletions charts/datahub/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ description: A Helm chart for LinkedIn DataHub
type: application
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
version: 0.3.19
version: 0.3.20
# This is the version number of the application being deployed. This version number should be
# incremented each time you make changes to the application.
appVersion: 0.12.1
Expand All @@ -14,7 +14,7 @@ dependencies:
repository: file://./subcharts/datahub-gms
condition: datahub-gms.enabled
- name: datahub-frontend
version: 0.2.151
version: 0.2.152
repository: file://./subcharts/datahub-frontend
condition: datahub-frontend.enabled
- name: datahub-mae-consumer
Expand Down
2 changes: 1 addition & 1 deletion charts/datahub/subcharts/datahub-frontend/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ description: A Helm chart for Kubernetes
type: application
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
version: 0.2.151
version: 0.2.152
# This is the version number of the application being deployed. This version number should be
# incremented each time you make changes to the application.
appVersion: v0.11.0
Original file line number Diff line number Diff line change
Expand Up @@ -220,15 +220,15 @@ spec:
{{- end }}
- name: AUTH_OIDC_BASE_URL
value: https://{{ (first $.Values.ingress.hosts).host }}
- name: AUTH_OIDC_USER_NAME_CLAIM
value: {{ .user_name_claim | default "email" }}
- name: AUTH_OIDC_USER_NAME_CLAIM_REGEX
value: {{ .user_name_claim_regex | default "([^@]+)" }}
{{- if eq .provider "google" }}
- name: AUTH_OIDC_DISCOVERY_URI
value: https://accounts.google.com/.well-known/openid-configuration
- name: AUTH_OIDC_SCOPE
value: {{ .scope | default "openid profile email" }}
- name: AUTH_OIDC_USER_NAME_CLAIM
value: {{ .user_name_claim | default "email" }}
- name: AUTH_OIDC_USER_NAME_CLAIM_REGEX
value: {{ .user_name_claim_regex | default "([^@]+)" }}
{{- else if eq .provider "okta" }}
- name: AUTH_OIDC_DISCOVERY_URI
value: https://{{ .oktaDomain }}/.well-known/openid-configuration
Expand Down

0 comments on commit 8a7c3cf

Please sign in to comment.