feat(chart): add custom label support for ServiceMonitor in DataHub c…

…harts This update allows the specification of custom labels for ServiceMonitor resources via the values.yaml file, mirroring the functionality already present for Service and Deployment resources. This enhancement facilitates better integration with monitoring systems like Prometheus that rely on specific labeling conventions for service discovery. Resolves: #449
acryldata · Apr 2, 2024 · 610516a · 610516a
1 parent 48f35a9
commit 610516a
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/charts/datahub/subcharts/datahub-frontend/templates/servicemonitor.yaml b/charts/datahub/subcharts/datahub-frontend/templates/servicemonitor.yaml
@@ -5,9 +5,9 @@ metadata:
   name: {{ printf "%s-%s" .Release.Name "datahub-frontend" }}
   labels:
     {{- include "datahub-frontend.labels" . | nindent 4 }}
-    {{ - range $key, $val := .Values.serviceMonitor.extraLabels }}
+    {{- range $key, $val := .Values.serviceMonitor.extraLabels }}
     {{ $key }}: {{ $val | quote }}
-    {{ - end }}
+    {{- end }}
   {{- with .Values.serviceMonitor.annotations }}
   annotations:
     {{- toYaml . | nindent 4 }}

diff --git a/charts/datahub/subcharts/datahub-gms/templates/servicemonitor.yaml b/charts/datahub/subcharts/datahub-gms/templates/servicemonitor.yaml
@@ -5,9 +5,9 @@ metadata:
   name: {{ printf "%s-%s" .Release.Name "datahub-gms" }}
   labels:
     {{- include "datahub-gms.labels" . | nindent 4 }}
-    {{ - range $key, $val := .Values.serviceMonitor.extraLabels }}
+    {{- range $key, $val := .Values.serviceMonitor.extraLabels }}
     {{ $key }}: {{ $val | quote }}
-    {{ - end }}
+    {{- end }}
   {{- with .Values.serviceMonitor.annotations }}
   annotations:
     {{- toYaml . | nindent 4 }}