Adding the support for custom labels to the datahub-frontend service (#…

…429) * adding custom labels to the datahub-frontend service * Update README.md * bumping the version in the parent chart * bumping the datahub chart version
acryldata · Feb 15, 2024 · 2d03ffc · 2d03ffc
1 parent ecb168d
commit 2d03ffc
Show file tree

Hide file tree

Showing 6 changed files with 10 additions and 3 deletions.
diff --git a/charts/datahub/Chart.yaml b/charts/datahub/Chart.yaml
@@ -4,7 +4,7 @@ description: A Helm chart for LinkedIn DataHub
 type: application
 # This is the chart version. This version number should be incremented each time you make changes
 # to the chart and its templates, including the app version.
-version: 0.3.28
+version: 0.3.29
 # This is the version number of the application being deployed. This version number should be
 # incremented each time you make changes to the application.
 appVersion: 0.12.1
@@ -14,7 +14,7 @@ dependencies:
     repository: file://./subcharts/datahub-gms
     condition: datahub-gms.enabled
   - name: datahub-frontend
-    version: 0.2.155
+    version: 0.2.156
     repository: file://./subcharts/datahub-frontend
     condition: datahub-frontend.enabled
   - name: datahub-mae-consumer

diff --git a/charts/datahub/subcharts/datahub-frontend/Chart.yaml b/charts/datahub/subcharts/datahub-frontend/Chart.yaml
@@ -12,7 +12,7 @@ description: A Helm chart for Kubernetes
 type: application
 # This is the chart version. This version number should be incremented each time you make changes
 # to the chart and its templates, including the app version.
-version: 0.2.155
+version: 0.2.156
 # This is the version number of the application being deployed. This version number should be
 # incremented each time you make changes to the application.
 appVersion: v0.11.0
diff --git a/charts/datahub/subcharts/datahub-frontend/README.md b/charts/datahub/subcharts/datahub-frontend/README.md
@@ -64,6 +64,7 @@ Current chart version is `0.2.0`
 | service.port                                                                | int                                                                                               | `9001`                              |                                                                                                                                                                                                                                                                                                                                  |
 | service.nodePort                                                            | int                                                                                               | `""`                                |                                                                                                                                                                                                                                                                                                                                  |
 | service.type                                                                | string                                                                                            | `"LoadBalancer"`                    |                                                                                                                                                                                                                                                                                                                                  |
+| service.extraLabels                                                         | object                                                                                            | `{}`                    |                                                                                                                                                                                                                                                                                                                                  |
 | serviceAccount.annotations                                                  | object                                                                                            | `{}`                                |                                                                                                                                                                                                                                                                                                                                  |
 | serviceAccount.create                                                       | bool                                                                                              | `true`                              |                                                                                                                                                                                                                                                                                                                                  |
 | serviceAccount.name                                                         | string                                                                                            | `nil`                               |                                                                                                                                                                                                                                                                                                                                  |

diff --git a/charts/datahub/subcharts/datahub-frontend/templates/service.yaml b/charts/datahub/subcharts/datahub-frontend/templates/service.yaml
@@ -4,6 +4,9 @@ metadata:
   name: {{ include "datahub-frontend.fullname" . }}
   labels:
     {{- include "datahub-frontend.labels" . | nindent 4 }}
+    {{- range $key, $val := .Values.service.extraLabels }}
+    {{ $key }}: {{ $val | quote }}
+    {{- end }}
   {{- with .Values.service.annotations }}
   annotations:
     {{- toYaml . | nindent 4 }}

diff --git a/charts/datahub/subcharts/datahub-frontend/values.yaml b/charts/datahub/subcharts/datahub-frontend/values.yaml
@@ -57,6 +57,7 @@ service:
   # Internal load balancer or various other annotation support in AWS
   annotations: {}
     # service.beta.kubernetes.io/aws-load-balancer-internal: "true"
+  extraLabels: {}
 
 serviceMonitor:
   create: false

diff --git a/charts/datahub/values.yaml b/charts/datahub/values.yaml
@@ -53,6 +53,8 @@ datahub-frontend:
   ingress:
     enabled: false
   defaultUserCredentials: {}
+  service:
+    extraLabels: {}
     # randomAdminPassword: true
     # You can also set specific passwords for default users
     # manualValues: |