Skip to content

Commit

Permalink
fix(auth): change service authentication default to true and add emai…
Browse files Browse the repository at this point in the history 
…l validation configuration (#398)

* fix(auth): change metdata service authentication default to true

* add email sign up config

* fix lint
  • Loading branch information
@RyanHolstien
RyanHolstien authored Nov 15, 2023
1 parent 741ecc2 commit 1c5990f
Show file tree
Hide file tree
Showing 19 changed files with 307 additions and 299 deletions.
12 changes: 6 additions & 6 deletions charts/datahub/Chart.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -4,33 +4,33 @@ description: A Helm chart for LinkedIn DataHub
type: application
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
version: 0.3.8
version: 0.3.9
# This is the version number of the application being deployed. This version number should be
# incremented each time you make changes to the application.
appVersion: 0.11.0
dependencies:
- name: datahub-gms
version: 0.2.154
version: 0.2.155
repository: file://./subcharts/datahub-gms
condition: datahub-gms.enabled
- name: datahub-frontend
version: 0.2.144
version: 0.2.145
repository: file://./subcharts/datahub-frontend
condition: datahub-frontend.enabled
- name: datahub-mae-consumer
version: 0.2.148
version: 0.2.149
repository: file://./subcharts/datahub-mae-consumer
condition: global.datahub_standalone_consumers_enabled
- name: datahub-mce-consumer
version: 0.2.151
version: 0.2.152
repository: file://./subcharts/datahub-mce-consumer
condition: global.datahub_standalone_consumers_enabled
- name: datahub-ingestion-cron
version: 0.2.137
repository: file://./subcharts/datahub-ingestion-cron
condition: datahub-ingestion-cron.enabled
- name: acryl-datahub-actions
version: 0.2.138
version: 0.2.139
repository: file://./subcharts/acryl-datahub-actions
condition: acryl-datahub-actions.enabled
maintainers:
Expand Down
104 changes: 52 additions & 52 deletions charts/datahub/README.md
View file

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion charts/datahub/subcharts/acryl-datahub-actions/Chart.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ description: A Helm chart for Kubernetes
type: application
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
version: 0.2.138
version: 0.2.139
# This is the version number of the application being deployed. This version number should be
# incremented each time you make changes to the application.
appVersion: 0.0.11
76 changes: 38 additions & 38 deletions charts/datahub/subcharts/acryl-datahub-actions/README.md
View file

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion charts/datahub/subcharts/acryl-datahub-actions/values.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ global:
gms:
port: "8080"
metadata_service_authentication:
enabled: false
enabled: true
systemClientId: "__datahub_system"
# systemClientSecret:
# secretRef: <secret-ref>
Expand Down
2 changes: 1 addition & 1 deletion charts/datahub/subcharts/datahub-frontend/Chart.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ description: A Helm chart for Kubernetes
type: application
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
version: 0.2.144
version: 0.2.145
# This is the version number of the application being deployed. This version number should be
# incremented each time you make changes to the application.
appVersion: v0.11.0
3 changes: 2 additions & 1 deletion charts/datahub/subcharts/datahub-frontend/README.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ Current chart version is `0.2.0`
| fullnameOverride | string | `"datahub-frontend"` | |
| global.datahub_analytics_enabled | boolean | true | |
| global.datahub.gms.port | string | `"8080"` | |
| global.datahub.frontend.validateSignUpEmail | boolean | true | Enforces user sign up through invite link to use a valid email. |
| image.pullPolicy | string | `"IfNotPresent"` | |
| image.repository | string | `"linkedin/datahub-frontend-react"` | |
| image.tag | string | `"head"` | |
Expand Down Expand Up @@ -66,7 +67,7 @@ Current chart version is `0.2.0`
| global.elasticsearch.host | string | `"elasticsearch"` | |
| global.elasticsearch.port | string | `"9200"` | |
| global.kafka.bootstrap.server | string | `"broker:9092"` | |
| datahub.metadata_service_authentication.enabled | bool | `false` | Whether Metadata Service Authentication is enabled. |
| datahub.metadata_service_authentication.enabled | bool | `true` | Whether Metadata Service Authentication is enabled. |
| global.datahub.metadata_service_authentication.systemClientId | string | `"__datahub_system"` | The internal system id that is used to communicate with DataHub GMS. Required if metadata_service_authentication is 'true'. |
| global.datahub.metadata_service_authentication.systemClientSecret.secretRef | string | `nil` | The reference to a secret containing the internal system secret that is used to communicate with DataHub GMS. Required if metadata_service_authentication is 'true'. |
| global.datahub.metadata_service_authentication.systemClientSecret.secretKey | string | `nil` | The key of a secret containing the internal system secret that is used to communicate with DataHub GMS. Required if metadata_service_authentication is 'true'. |
2 changes: 2 additions & 0 deletions charts/datahub/subcharts/datahub-frontend/templates/deployment.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -114,6 +114,8 @@ spec:
value: "{{ .Values.global.datahub_analytics_enabled }}"
- name: KAFKA_BOOTSTRAP_SERVER
value: "{{ .Values.global.kafka.bootstrap.server }}"
- name: ENFORCE_VALID_EMAIL
value: "{{ .Values.global.datahub.frontend.validateSignUpEmail }}"
{{- with .Values.global.kafka.producer.compressionType }}
- name: KAFKA_PRODUCER_COMPRESSION_TYPE
value: "{{ . }}"
Expand Down
4 changes: 3 additions & 1 deletion charts/datahub/subcharts/datahub-frontend/values.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -225,8 +225,10 @@ global:
monitoring:
enablePrometheus: true
appVersion: "1.0"
frontend:
validateSignUpEmail: true
metadata_service_authentication:
enabled: false
enabled: true
systemClientId: "__datahub_system"
# systemClientSecret:
# secretRef: <secret-ref>
Expand Down
2 changes: 1 addition & 1 deletion charts/datahub/subcharts/datahub-gms/Chart.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ description: A Helm chart for LinkedIn DataHub's datahub-gms component
type: application
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
version: 0.2.154
version: 0.2.155
# This is the version number of the application being deployed. This version number should be
# incremented each time you make changes to the application.
appVersion: v0.11.0
Loading

0 comments on commit 1c5990f

Please sign in to comment.