Skip to content

Commit

Permalink
feat(telemetry): Add toggle for telemetry
Browse files Browse the repository at this point in the history
  • Loading branch information
pedro93 authored Sep 19, 2023
1 parent ef63fae commit 11df627
Show file tree
Hide file tree
Showing 11 changed files with 33 additions and 11 deletions.
10 changes: 5 additions & 5 deletions charts/datahub/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,33 +4,33 @@ description: A Helm chart for LinkedIn DataHub
type: application
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
version: 0.2.188
version: 0.2.189
# This is the version number of the application being deployed. This version number should be
# incremented each time you make changes to the application.
appVersion: 0.11.0
dependencies:
- name: datahub-gms
version: 0.2.151
version: 0.2.152
repository: file://./subcharts/datahub-gms
condition: datahub-gms.enabled
- name: datahub-frontend
version: 0.2.141
repository: file://./subcharts/datahub-frontend
condition: datahub-frontend.enabled
- name: datahub-mae-consumer
version: 0.2.147
version: 0.2.148
repository: file://./subcharts/datahub-mae-consumer
condition: global.datahub_standalone_consumers_enabled
- name: datahub-mce-consumer
version: 0.2.150
version: 0.2.151
repository: file://./subcharts/datahub-mce-consumer
condition: global.datahub_standalone_consumers_enabled
- name: datahub-ingestion-cron
version: 0.2.136
repository: file://./subcharts/datahub-ingestion-cron
condition: datahub-ingestion-cron.enabled
- name: acryl-datahub-actions
version: 0.2.138
version: 0.2.139
repository: file://./subcharts/acryl-datahub-actions
condition: acryl-datahub-actions.enabled
maintainers:
Expand Down
2 changes: 1 addition & 1 deletion charts/datahub/subcharts/acryl-datahub-actions/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ description: A Helm chart for Kubernetes
type: application
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
version: 0.2.138
version: 0.2.139
# This is the version number of the application being deployed. This version number should be
# incremented each time you make changes to the application.
appVersion: 0.0.11
Original file line number Diff line number Diff line change
Expand Up @@ -120,6 +120,8 @@ spec:
- name: PLATFORM_EVENT_TOPIC_NAME
value: {{ .platform_event_topic_name }}
{{- end }}
- name: DATAHUB_TELEMETRY_ENABLED
value: "false"
{{- if .Values.global.datahub.metadata_service_authentication.enabled }}
- name: DATAHUB_SYSTEM_CLIENT_ID
value: {{ .Values.global.datahub.metadata_service_authentication.systemClientId }}
Expand Down
2 changes: 1 addition & 1 deletion charts/datahub/subcharts/datahub-gms/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ description: A Helm chart for LinkedIn DataHub's datahub-gms component
type: application
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
version: 0.2.151
version: 0.2.152
# This is the version number of the application being deployed. This version number should be
# incremented each time you make changes to the application.
appVersion: v0.11.0
10 changes: 10 additions & 0 deletions charts/datahub/subcharts/datahub-gms/templates/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -366,6 +366,16 @@ spec:
- name: search-config
mountPath: "/datahub/datahub-gms/resources/search"
{{- end }}
{{- with .Values.global.telemetry }}
- name: DATAHUB_TELEMETRY_ENABLED
value: {{ or (eq .cli "true") (eq .ingestReporting "true") (eq .thirdParty "true") | quote }}
- name: CLI_TELEMETRY_ENABLED
value: {{ .cli | quote }}
- name: INGESTION_REPORTING_ENABLED
value: {{ .ingestReporting | quote }}
- name: ENABLE_THIRD_PARTY_LOGGING
value: {{ .thirdParty | quote }}
{{- end }}
{{- with .Values.extraVolumeMounts }}
{{- toYaml . | nindent 12 }}
{{- end }}
Expand Down
5 changes: 4 additions & 1 deletion charts/datahub/subcharts/datahub-gms/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -181,13 +181,16 @@ global:

datahub:
version: head
telemetry:
cli: false
ingestReporting: true
thirdParty: true
monitoring:
enablePrometheus: false
enableJMXPort: false
gms:
port: "8080"
appVersion: "1.0"

systemUpdate:
## The following options control settings for datahub-upgrade job which will
## managed ES indices and other update related work
Expand Down
2 changes: 1 addition & 1 deletion charts/datahub/subcharts/datahub-mae-consumer/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ description: A Helm chart for Kubernetes
type: application
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
version: 0.2.147
version: 0.2.148
# This is the version number of the application being deployed. This version number should be
# incremented each time you make changes to the application.
appVersion: v0.11.0
Original file line number Diff line number Diff line change
Expand Up @@ -229,6 +229,8 @@ spec:
value: {{ .Values.global.datahub.alwaysEmitChangeLog | quote }}
- name: GRAPH_SERVICE_DIFF_MODE_ENABLED
value: {{ .Values.global.datahub.enableGraphDiffMode | quote }}
- name: DATAHUB_TELEMETRY_ENABLED
value: "false"
{{- with .Values.extraEnvs }}
{{- toYaml . | nindent 12 }}
{{- end }}
Expand Down
2 changes: 1 addition & 1 deletion charts/datahub/subcharts/datahub-mce-consumer/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ description: A Helm chart for Kubernetes
type: application
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
version: 0.2.150
version: 0.2.151
# This is the version number of the application being deployed. This version number should be
# incremented each time you make changes to the application.
appVersion: v0.11.0
Original file line number Diff line number Diff line change
Expand Up @@ -242,6 +242,8 @@ spec:
value: {{ .Values.global.datahub.alwaysEmitChangeLog | quote }}
- name: GRAPH_SERVICE_DIFF_MODE_ENABLED
value: {{ .Values.global.datahub.enableGraphDiffMode | quote }}
- name: DATAHUB_TELEMETRY_ENABLED
value: "false"
{{- with .Values.extraEnvs }}
{{- toYaml . | nindent 12 }}
{{- end }}
Expand Down
5 changes: 4 additions & 1 deletion charts/datahub/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -321,7 +321,10 @@ global:
graph_service_impl: elasticsearch
datahub_analytics_enabled: true
datahub_standalone_consumers_enabled: false

telemetry:
cli: false
ingestReporting: true
thirdParty: true
elasticsearch:
host: "elasticsearch-master"
port: "9200"
Expand Down

0 comments on commit 11df627

Please sign in to comment.