feat(actions): add docs propagation action for columns #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hsheth2
approved these changes
Sep 9, 2024
| # No need to propagate to self | ||
| return None | ||
|
|
||
| if not dataset_urn.startswith("urn:li:dataset"): |
There was a problem hiding this comment.
we have utils e.g. from datahub.metadata.urns import Dataset or guess_entity_type - this startswith check feels a bit too hardcoded
There was a problem hiding this comment.
i have seen this in a code quite a bit recently. i agree with avoiding raw strings for urn checks. seems like python sdk should have internal utilities for all of this
datahub-actions/src/datahub_actions/plugin/action/propagation/docs/propagation_action.py
Show resolved
Hide resolved
datahub-actions/src/datahub_actions/plugin/action/propagation/docs/propagation_action.py
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new DocPropagationAction for column-level documentation propagation.
Key features include:
As seen in DataHub townhall - https://youtu.be/hdqgjxiW-zI?t=2051