Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(base-image): update base image #125

Merged
merged 1 commit into from
Sep 3, 2024
Merged

feat(base-image): update base image #125

merged 1 commit into from
Sep 3, 2024

Conversation

david-leifker
Copy link
Contributor

@david-leifker david-leifker commented Aug 30, 2024 •
edited
Loading

Will tag this image as actions v0.1.0

  • update base ingestion image
  • fix gha permission
  • fix lint errors

@david-leifker david-leifker changed the title feat(base-image): update base image to ubuntu feat(base-image): update base image Aug 30, 2024
@david-leifker david-leifker requested a review from hsheth2 August 30, 2024 19:26
hsheth2
hsheth2 approved these changes Aug 30, 2024
View reviewed changes
Copy link
Contributor

@hsheth2 hsheth2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what the pip cache changes will to do install times, but otherwise looks good

@david-leifker david-leifker force-pushed the actions-ingest-base-update branch 3 times, most recently from d5e9e24 to 5ddda00 Compare August 30, 2024 21:11
@david-leifker
Copy link
Contributor Author

david-leifker commented Aug 30, 2024 •
edited
Loading

Not sure what the pip cache changes will to do install times, but otherwise looks good

Putting the cache dir back and in the right spot /datahub-ingestion/.cache

@david-leifker david-leifker force-pushed the actions-ingest-base-update branch 3 times, most recently from 7413713 to 209320c Compare September 1, 2024 17:13
@david-leifker david-leifker force-pushed the actions-ingest-base-update branch from 209320c to f9a7f20 Compare September 3, 2024 15:13
@david-leifker david-leifker merged commit cd2f68d into main Sep 3, 2024
2 checks passed
@david-leifker david-leifker deleted the actions-ingest-base-update branch September 3, 2024 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hsheth2 hsheth2 hsheth2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@david-leifker @hsheth2