fix(notifications): fix wrong urls in ms teams notifications #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjoyce0510
reviewed
Jul 1, 2024
| @@ -65,3 +65,7 @@ def make_datahub_url(urn: str, base_url: str) -> str: | |||
| entity_type = entity_type_from_urn(urn) | |||
| urn = urn.replace("/", "%2F") | |||
| return f"{base_url}/{ENTITY_TYPE_TO_URL_PATH_MAP[entity_type]}/{urn}/" | |||
|
|
|||
| def make_entity_url(urn: str, entity_type: str, base_url: str) -> str: | |||
There was a problem hiding this comment.
We may want to do even more general-purpose URL encoding here! There should be an easy to use python method for this :)
shirshanka
force-pushed
the
fix-links
branch
from
770be2c to
175affe
Compare
Unit Test Results (build & test)0 tests 0 ✅ 0s ⏱️ Results for commit 175affe. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Links for datasets like a file are not correct in Teams notifications.
Part of delimiters "/" in a URL should be replaced on "%2F" symbols.
For example, before changes:
http://xx.xx.xx.xx:9002/dataset/urn:li:dataset:(urn:li:dataPlatform:dbfs,/dream_team/cross_banner,PROD)/Schema?schemaFilter=ban_1_Banner
And after changes:
http://xx.xx.xx.xx:9002/dataset/urn:li:dataset:(urn:li:dataPlatform:dbfs,%2Fdream_team%2Fcross_banner,PROD)/Schema?schemaFilter=ban_1_Banner