Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ACMS-000: Include MultisiteDrush commands #29

Merged
merged 2 commits into from
Jan 17, 2024
Merged

ACMS-000: Include MultisiteDrush commands #29

merged 2 commits into from
Jan 17, 2024

Conversation

vishalkhode1
Copy link
Contributor

Motivation
Moved Multisite settings.php generation logic in acquia/drupal-recommended-settings.

Proposed changes
Moved business logic from vishalkhode1/acquia_global_commands in DRS.

Alternatives considered
N/A

Testing steps
Run command ./vendor/bin/drush site:install --uri=site1 and you should see multisite setup in local/CloudIDE.

Copy link
Contributor

@rajeshreeputra rajeshreeputra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is requesting to drop a table in the database, even though it's a new site and the database is being created for the first time.

src/Drush/Commands/MultisiteDrushCommands.php Outdated Show resolved Hide resolved
Copy link
Contributor

@chandan-singh7929 chandan-singh7929 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall changes are good, I have some observation please take a look.

@vishalkhode1 vishalkhode1 merged commit dd0bcf8 into develop Jan 17, 2024
2 checks passed
@vishalkhode1 vishalkhode1 deleted the testing branch January 17, 2024 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants