ACMS-4246: Refactor Acquia Starter Kit Search to work with recipe. #1915
+588
−153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rajeshreeputra
requested review from
chandan-singh7929,
vishalkhode1,
apathak18 and
deepakmishra2
rajeshreeputra
force-pushed
the
ACMS-4246-refactor
branch
from
8036365 to
6921df3
Compare
rajeshreeputra
temporarily deployed
to
acquia_code_deployment
GitHub Actions
Inactive
rajeshreeputra
temporarily deployed
to
acquia_code_deployment
GitHub Actions
Inactive
rajeshreeputra
temporarily deployed
to
acquia_code_deployment
GitHub Actions
Inactive
rajeshreeputra
temporarily deployed
to
acquia_code_deployment
GitHub Actions
Inactive
rajeshreeputra
force-pushed
the
ACMS-4246-refactor
branch
from
3659734 to
0c160f9
Compare
rajeshreeputra
temporarily deployed
to
acquia_code_deployment
GitHub Actions
Inactive
rajeshreeputra
temporarily deployed
to
acquia_code_deployment
GitHub Actions
Inactive
rajeshreeputra
temporarily deployed
to
acquia_code_deployment
GitHub Actions
Inactive
rajeshreeputra
temporarily deployed
to
acquia_code_deployment
GitHub Actions
Inactive
rajeshreeputra
force-pushed
the
ACMS-4246-refactor
branch
from
59deb27 to
15998b4
Compare
rajeshreeputra
temporarily deployed
to
acquia_code_deployment
GitHub Actions
Inactive
apathak18
reviewed
Dec 31, 2024
| @@ -24,21 +24,16 @@ function acquia_cms_search_install($is_syncing) { | |||
|
|
|||
| // Retroactively enable indexing for any content types that existed before | |||
| // this module was installed. | |||
| $node_types = NodeType::loadMultiple(); | |||
| $node_types = \Drupal::entityTypeManager()->getStorage('node_type')->loadMultiple(); | |||
There was a problem hiding this comment.
Replace with below lines
$entity_type_manager = \Drupal::entityTypeManager();
$node_types = $entity_type_manager->getStorage('node_type')->loadMultiple();
apathak18
reviewed
Dec 31, 2024
| $enabled_modules = array_keys($enabled_modules); | ||
| _acquia_cms_search_add_category_facet($enabled_modules); | ||
| array_walk($node_types, '_acquia_cms_search_import_content_type_views'); | ||
| $search_category = \Drupal::entityTypeManager()->getStorage('facets_facet')->loadByProperties(['id' => 'search_category']); |
There was a problem hiding this comment.
$search_category = $entity_type_manager->getStorage('facets_facet')->loadByProperties(['id' => 'search_category']);
apathak18
reviewed
Dec 31, 2024
| } | ||
|
|
||
| /** | ||
| * Implements hook_ENTITY_TYPE_insert() for node types. |
apathak18
reviewed
Dec 31, 2024
| * @return bool | ||
| * TRUE if the configuration exists, FALSE otherwise. | ||
| */ | ||
| function configExists($config_name) { |
There was a problem hiding this comment.
this method is called only at one instance.. can we directly implement the code block where this method called.
Pros: We can avoid the introducing of new method.
Just a suggestion!!
rajeshreeputra
temporarily deployed
to
acquia_code_deployment
GitHub Actions
Inactive
rajeshreeputra
temporarily deployed
to
acquia_code_deployment
GitHub Actions
Inactive
rajeshreeputra
force-pushed
the
ACMS-4246-refactor
branch
from
89d00a8 to
2dcd9b0
Compare
rajeshreeputra
temporarily deployed
to
acquia_code_deployment
GitHub Actions
Inactive
rajeshreeputra
force-pushed
the
ACMS-4246-refactor
branch
from
2dcd9b0 to
825ba7b
Compare
rajeshreeputra
temporarily deployed
to
acquia_code_deployment
GitHub Actions
Inactive
rajeshreeputra
force-pushed
the
ACMS-4246-refactor
branch
from
825ba7b to
443f67c
Compare
rajeshreeputra
temporarily deployed
to
acquia_code_deployment
GitHub Actions
Inactive
rajeshreeputra
force-pushed
the
ACMS-4246-refactor
branch
from
443f67c to
116c5d0
Compare
rajeshreeputra
temporarily deployed
to
acquia_code_deployment
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fixes #NNN
Proposed changes
Alternatives considered
Testing steps
Merge requirements