ACMS-4401: Replace hook hook_content_model_role_presave_alter for Acquia Starter Kit media modules with hook_entity_insert. #1911
+1,333
−748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rajeshreeputra
assigned chandan-singh7929 and apathak18 and unassigned chandan-singh7929 and apathak18
rajeshreeputra
temporarily deployed
to
acquia_code_deployment
GitHub Actions
Inactive
rajeshreeputra
temporarily deployed
to
acquia_code_deployment
GitHub Actions
Inactive
rajeshreeputra
force-pushed
the
ACMS-4373-media
branch
from
c923fa0 to
6b24b20
Compare
rajeshreeputra
temporarily deployed
to
acquia_code_deployment
GitHub Actions
Inactive
…uia Starter Kit media modules with hook_entity_insert.
rajeshreeputra
force-pushed
the
ACMS-4373-media
branch
from
6b24b20 to
66f4cb6
Compare
rajeshreeputra
temporarily deployed
to
acquia_code_deployment
GitHub Actions
Inactive
rajeshreeputra
temporarily deployed
to
acquia_code_deployment
GitHub Actions
Inactive
rajeshreeputra
temporarily deployed
to
acquia_code_deployment
GitHub Actions
Inactive
rajeshreeputra
commented
Dec 27, 2024
| @@ -4,6 +4,7 @@ description: 'Provides an Event content type and related configuration.' | |||
| type: module | |||
| core_version_requirement: ^9.4 || ^10 || ^11 | |||
| dependencies: | |||
| - acquia_cms_common:acquia_cms_common | |||
There was a problem hiding this comment.
FYI: The dependency on the acquia_cms_common module will be removed for content model to function independently in separate PR.
Same apply for all other content type modules.
| @@ -4,6 +4,7 @@ | |||
| "license": "GPL-2.0-or-later", | |||
| "type": "drupal-module", | |||
| "require": { | |||
| "drupal/acquia_cms_common": "^1.9 || ^2.1 || ^3.1", | |||
There was a problem hiding this comment.
FYI: The dependency on the acquia_cms_common module will be removed for content model to function independently in separate PR.
Same apply for all other content type modules.
rajeshreeputra
force-pushed
the
ACMS-4373-media
branch
from
321c67f to
3caa809
Compare
rajeshreeputra
temporarily deployed
to
acquia_code_deployment
GitHub Actions
Inactive
rajeshreeputra
changed the title
rajeshreeputra
temporarily deployed
to
acquia_code_deployment
GitHub Actions
Inactive
rajeshreeputra
temporarily deployed
to
acquia_code_deployment
GitHub Actions
Inactive
rajeshreeputra
force-pushed
the
ACMS-4373-media
branch
from
1c9c4d4 to
e9aeb28
Compare
rajeshreeputra
temporarily deployed
to
acquia_code_deployment
GitHub Actions
Inactive
rajeshreeputra
temporarily deployed
to
acquia_code_deployment
GitHub Actions
Inactive
rajeshreeputra
force-pushed
the
ACMS-4373-media
branch
from
b036e2d to
4e1a660
Compare
rajeshreeputra
temporarily deployed
to
acquia_code_deployment
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fixes #ACMS-4401
Proposed changes
Replace hook_content_model_role_presave_alter for Acquia Starter Kit media modules with hook_entity_insert.
Alternatives considered
NA
Testing steps
Follow from ticket.
Merge requirements