Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ACMS-4373: Make Acquia CMS Toolbar and Tour work independent. #1909

Merged
merged 14 commits into from
Dec 27, 2024
Merged

ACMS-4373: Make Acquia CMS Toolbar and Tour work independent. #1909

merged 14 commits into from
Dec 27, 2024

Conversation

rajeshreeputra
Copy link
Contributor

Motivation
Toolbar and Tour should work independently without the Acquia Drupal Starter Kit Common module.
Fixes #ACMS-4373

Proposed changes
Remove Acquia Drupal Starter Kit Common module dependency.

Alternatives considered
NA

Testing steps
Follow from ticket

Merge requirements

  • Major change, Minor change, Bug, Enhancement, and/or Chore label applied
  • Manual testing by a reviewer

@rajeshreeputra rajeshreeputra temporarily deployed to acquia_code_deployment December 20, 2024 09:03 — with GitHub Actions Inactive
@rajeshreeputra rajeshreeputra temporarily deployed to acquia_code_deployment December 20, 2024 09:10 — with GitHub Actions Inactive
@rajeshreeputra rajeshreeputra temporarily deployed to acquia_code_deployment December 20, 2024 09:29 — with GitHub Actions Inactive
@rajeshreeputra rajeshreeputra temporarily deployed to acquia_code_deployment December 20, 2024 09:34 — with GitHub Actions Inactive
@rajeshreeputra rajeshreeputra temporarily deployed to acquia_code_deployment December 20, 2024 10:55 — with GitHub Actions Inactive
@rajeshreeputra rajeshreeputra temporarily deployed to acquia_code_deployment December 20, 2024 13:17 — with GitHub Actions Inactive
@rajeshreeputra rajeshreeputra temporarily deployed to acquia_code_deployment December 23, 2024 03:55 — with GitHub Actions Inactive
@rajeshreeputra rajeshreeputra temporarily deployed to acquia_code_deployment December 23, 2024 04:55 — with GitHub Actions Inactive
@rajeshreeputra rajeshreeputra temporarily deployed to acquia_code_deployment December 23, 2024 04:57 — with GitHub Actions Inactive
@rajeshreeputra rajeshreeputra temporarily deployed to acquia_code_deployment December 23, 2024 05:08 — with GitHub Actions Inactive
@rajeshreeputra rajeshreeputra temporarily deployed to acquia_code_deployment December 23, 2024 08:55 — with GitHub Actions Inactive
@rajeshreeputra rajeshreeputra temporarily deployed to acquia_code_deployment December 23, 2024 09:16 — with GitHub Actions Inactive
@rajeshreeputra rajeshreeputra temporarily deployed to acquia_code_deployment December 24, 2024 06:44 — with GitHub Actions Inactive
@rajeshreeputra rajeshreeputra temporarily deployed to acquia_code_deployment December 26, 2024 05:28 — with GitHub Actions Inactive
@rajeshreeputra rajeshreeputra temporarily deployed to acquia_code_deployment December 26, 2024 06:36 — with GitHub Actions Inactive
@rajeshreeputra rajeshreeputra temporarily deployed to acquia_code_deployment December 26, 2024 07:05 — with GitHub Actions Inactive
@rajeshreeputra rajeshreeputra temporarily deployed to acquia_code_deployment December 26, 2024 08:12 — with GitHub Actions Inactive
@rajeshreeputra rajeshreeputra temporarily deployed to acquia_code_deployment December 26, 2024 08:53 — with GitHub Actions Inactive
@rajeshreeputra rajeshreeputra temporarily deployed to acquia_code_deployment December 26, 2024 09:11 — with GitHub Actions Inactive
@rajeshreeputra rajeshreeputra temporarily deployed to acquia_code_deployment December 26, 2024 09:38 — with GitHub Actions Inactive
@rajeshreeputra rajeshreeputra temporarily deployed to acquia_code_deployment December 27, 2024 07:52 — with GitHub Actions Inactive
@rajeshreeputra rajeshreeputra temporarily deployed to acquia_code_deployment December 27, 2024 08:11 — with GitHub Actions Inactive
@rajeshreeputra rajeshreeputra temporarily deployed to acquia_code_deployment December 27, 2024 08:40 — with GitHub Actions Inactive
@rajeshreeputra rajeshreeputra temporarily deployed to acquia_code_deployment December 27, 2024 10:16 — with GitHub Actions Inactive
@rajeshreeputra rajeshreeputra mentioned this pull request Dec 27, 2024
Closed
2 tasks
@vishalkhode1 vishalkhode1 merged commit dc1ac52 into develop Dec 27, 2024
35 of 42 checks passed
@vishalkhode1 vishalkhode1 deleted the ACMS-4373 branch December 27, 2024 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chandan-singh7929 chandan-singh7929 Awaiting requested review from chandan-singh7929

@vishalkhode1 vishalkhode1 Awaiting requested review from vishalkhode1

@apathak18 apathak18 Awaiting requested review from apathak18

@deepakmishra2 deepakmishra2 Awaiting requested review from deepakmishra2

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rajeshreeputra @apathak18 @vishalkhode1