Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add myself as a sysadmin #1032

Merged
merged 2 commits into from
Sep 24, 2024
Merged

add myself as a sysadmin #1032

merged 2 commits into from
Sep 24, 2024

Conversation

lowpolyneko
Copy link
Contributor

Description

Added myself as a sysadmin :3 Also, the officers.md page has historically had Sysadmin/Webmaster listed in the table, is that no longer a thing?

Checklist

  • I've labeled the PR appropriately.
  • I've have built the website and verified that my changes work.
  • I've linked the appropriate issues and related PRs.

@lowpolyneko lowpolyneko self-assigned this Sep 24, 2024
@lowpolyneko lowpolyneko requested a review from a team as a code owner September 24, 2024 16:57
Copy link
Contributor

@clee231 clee231 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding yourself! ❤️
Everyone on the ACM Council should generally be added to the officers.md as well. This includes SysAdmins, Webmasters, SIG/Tech Leaders, etc.

I believe the current list was sourced from one of the documents Yashi made in the council chat that was made before the semester started.

@lowpolyneko
Copy link
Contributor Author

i can append it to the table, but i don't actually know who wants to be on the table lol. i'm happy to be on it, but idk if you or soham or bharat want to be on the list either. for now i'll just merge this and if people want that to be updated another pr can be done.

@lowpolyneko lowpolyneko enabled auto-merge (squash) September 24, 2024 18:05
@lowpolyneko lowpolyneko enabled auto-merge (squash) September 24, 2024 18:07
@lowpolyneko
Copy link
Contributor Author

lol wait it cant get merged cus of #1031, ig i'll just keep auto-merge on. i honestly don't know enough about the eslint config to rewrite it in the flat format so i'll wait in the meantime.

@clee231 clee231 disabled auto-merge September 24, 2024 20:35
@clee231 clee231 enabled auto-merge (squash) September 24, 2024 20:35
@clee231
Copy link
Contributor

clee231 commented Sep 24, 2024

This PR shouldn't be dependent on #1031, since that version bump hasn't been merged yet.

I think the pipeline is complaining about a linting issue. I'll look into it a bit more after work.

@clee231 clee231 merged commit 60356dd into acm-uic:main Sep 24, 2024
7 checks passed
@clee231
Copy link
Contributor

clee231 commented Sep 24, 2024

As I expected, it was just a linting error. After fixing that, the pipeline succeeded and I was able to auto-merge.

@lowpolyneko
Copy link
Contributor Author

oh im an idiot, thanks chase :D

@lowpolyneko lowpolyneko deleted the new-sysadmin branch September 25, 2024 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants