Make Latexrun work on Windows #50
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Convert Windows line endings into Unix ones, for correct processing downstream.
`os.rename` doesn't behave correctly on Windows, and causes a `WinError` exception. `os.replace` seems to be the better way to do atomic renames, and also works on Windows.
Use `os.path.isabs` instead of manually detecting an initial forward slash. This also works on Windows.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes enabled me to use
latexrunon Windows (with MikTeX). Just some minor fixes of path and stdout handling. At this point I can't guarantee that everything works as intended, but it seems to do the trick for now. I hope this helps someone out there!In any case, thanks for putting
latexrunout here. It's a very helpful utility :-)