Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Okular not refreshing updated pdf. #26

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mhoogendoorn
Copy link

Okular (using KDE Frameworks 5) does not automatically reload if the pdf
is updated. This commit adds a touch in LatexCommit._execute if the
pdf has changed.

Using os.utime as it updates modification time. This means it still
works on filesystems mounted with noatime.

Note:
I do not know if other pdf viewers have the same problem and as Okular in KDE4 did not need this, it might just be a regression in Okular. Haven't had time to look into Okular itself yet.

Pull request in case other viewers have the same problem.

Okular (using KDE Frameworks 5) does not automatically reload if the pdf
is updated. This commit adds a `touch` in `LatexCommit._execute` if the
pdf has changed.

Using `os.utime` as it updates modification time. This means it still
works on filesystems mounted with `noatime`.
@orangenschalen
Copy link

orangenschalen commented May 8, 2017

Please merge this fix. The commit message is:

Okular (using KDE Frameworks 5) does not automatically reload if the pdf
is updated. This commit adds a touch in LatexCommit._execute if the
pdf has changed.

Using os.utime as it updates modification time. This means it still
works on filesystems mounted with noatime.

I can't confirm whether the rational, that the noatime option of the mounted filesystem is the culprit here, is correct. But I can confirm, that the problem exists, and that this patch fixes it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants