Fix Record not working if re-recording immediately

acidbubbles · Nov 27, 2022 · 73d6be9 · 73d6be9
1 parent cb1cfdc
commit 73d6be9
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/src/AtomAnimations/Animations/AtomAnimation.Playback.cs b/src/AtomAnimations/Animations/AtomAnimation.Playback.cs
@@ -355,6 +355,7 @@ public void StopAll()
             {
                 StopClip(clip);
             }
+            playTime = 0f;
             foreach (var clip in clips)
             {
                 clip.Reset(false);

diff --git a/src/AtomAnimations/Operations/RecordOperations.cs b/src/AtomAnimations/Operations/RecordOperations.cs
@@ -1,4 +1,5 @@
-using System.Collections;
+using System;
+using System.Collections;
 using System.Collections.Generic;
 using System.Linq;
 using UnityEngine;
@@ -28,6 +29,12 @@ public IEnumerator StartRecording(
             bool exitOnMenuOpen,
             bool showStartMarkers)
         {
+            if (!recordExtendsLength && _clip.clipTime >= _clip.animationLength - 0.001)
+            {
+                SuperController.LogError("Timeline: Animation is already at the end; either enable extends recording or rewind.");
+                yield break;
+            }
+
             if (_animation.recording)
             {
                 SuperController.LogError("Timeline: Already recording");
@@ -225,7 +232,7 @@ private void AfterRecording(List<ICurveAnimationTarget> targets)
                 target.EndBulkUpdates();
             }
 
-            _clip.clipTime = Mathf.Min(_clip.animationLength, _clip.clipTime).Snap();
+            _animation.StopAll();
         }
 
         private static void ClearAllGrabbedControllers(IEnumerable<ICurveAnimationTarget> targets)