-
Notifications
You must be signed in to change notification settings - Fork 4
Minimum Refectoring #2
base: develop
Are you sure you want to change the base?
Conversation
toliner
commented
Dec 21, 2017
- 変数名とクラス名が同じであることとusing staticの使用に起因する曖昧な参照の解決
- usingの最適化
<ItemGroup> | ||
<PackageReference Include="System.Net.Ping" Version="4.3.0" /> | ||
<PackageReference Include="Discord.Net" Version="1.0.2" /> | ||
<PackageReference Include="LiteDB" Version="4.1.0" /> | ||
</ItemGroup> | ||
|
||
</Project> | ||
</Project> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All of the ends of files have to be finished with a new line.
using System.Threading.Tasks; | ||
using AcidChicken.Samurai.Models; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All of the local namespace reference instructions have to be included in the local namespace block.
@@ -4,16 +4,14 @@ | |||
using System.Reflection; | |||
using System.Text; | |||
using System.Threading.Tasks; | |||
using AcidChicken.Samurai.Assets; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All of the local namespace reference instructions have to be included in the local namespace block.
@@ -4,16 +4,14 @@ | |||
using System.Reflection; | |||
using System.Text; | |||
using System.Threading.Tasks; | |||
using AcidChicken.Samurai.Assets; | |||
using AcidChicken.Samurai.Components; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All of the local namespace reference instructions have to be included in the local namespace block.
using System.Linq; | ||
using System.Threading.Tasks; | ||
using AcidChicken.Samurai.Assets; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All of the local namespace reference instructions have to be included in the local namespace block.
@@ -1,13 +1,10 @@ | |||
using System; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The "System" reference instruction must be defined at the top of the code file.
@@ -1,6 +1,4 @@ | |||
using System; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The "System" reference instruction must be defined at the top of the code file.
@@ -1,10 +1,7 @@ | |||
using System; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The "System" reference instruction must be defined at the top of the code file.
@@ -1,15 +1,12 @@ | |||
using System; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The "System" reference instruction must be defined at the top of the code file.
@@ -1,17 +1,16 @@ | |||
using System; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The "System" reference instruction must be defined at the top of the code file.