Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the inline css in html files and put it to the custom.css file #388

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Remove the inline css in html files and put it to the custom.css file #388

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
b9d5061
Remove the inline css in html files and put it to the custom.css file
YoshithaRathnayake Feb 2, 2022
003e4a1
Merge branch 'master' into inline-css
YoshithaRathnayake Jun 15, 2022
4cc0d95
Add padding-top and bottom using bootstrap
YoshithaRathnayake Jun 16, 2022
8e6c0da
Merge branch 'inline-css' of https://github.com/Yoshitha-SACK/sack-si…
YoshithaRathnayake Jun 16, 2022
22d382a
Merge branch 'master' into inline-css
YoshithaRathnayake Jun 17, 2022
5934c1c
Remove the custom width and move the row into a container
YoshithaRathnayake Jun 18, 2022
bc34321
Merge branch 'inline-css' of https://github.com/Yoshitha-SACK/sack-si…
YoshithaRathnayake Jun 18, 2022
350346a
Use an h4 instead of custom css to the Since 1854 text
YoshithaRathnayake Jun 18, 2022
d4a2eb2
Move the container class to line 76 and remove d-flex justify-content…
YoshithaRathnayake Jun 18, 2022
695bf0e
Remove the row and a col in lines 10 and 11
YoshithaRathnayake Jun 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions assets/css/custom.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,16 @@
color: #00316A;
}

.since-btn {
font-family: 'Roboto';
font-size: 20px;
font-weight: 400;
}

.quick-access-cards {
width: 71rem;
}

.contact-us .google-map {
position: relative;
bottom: 8px;
Expand Down
4 changes: 2 additions & 2 deletions index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
<div class="col-md-12 ml-auto mr-auto">
<div class="title text-left">
<h1>St. Anthony's College</h1>
<p style="font-family: 'Roboto'; font-size: 20px; font-weight: 400;">
<p class="since-btn">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's just use an h4 instead of custom css.

Since 1854
</p>
</div>
Expand Down Expand Up @@ -74,7 +74,7 @@ <h4 class="card-title">Nam aliquam bibendum ullamcorper. Praesent tempor</h4>
<div class="section pt-0 ">
<h2 class="section-name"> Quick Access </h2>
<div class="d-flex justify-content-center">
<div class="row" style="width: 71rem;">
<div class="row quick-access-cards">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job @YoshithaRathnayake
Could you please try to add this change using existing bootstrap CSS?
You can refer to this: https://getbootstrap.com/docs/4.0/layout/grid/#offsetting-columns

Btw, I think it will be easier for you to complete #358 and #375 together with the same PR.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I thought that puting in bootstrap is good

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Piumal1999

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the custom width and move the row into a container. It will set the width automatically.

<div class="col-md-6">
<div class="card">
<div class="card-body pt-2">
Expand Down