Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove custom CSS that effects globally #46

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

YoshithaRathnayake
Copy link
Member

@YoshithaRathnayake YoshithaRathnayake commented Feb 13, 2022

Purpose

The purpose of this PR is to fix #44

Goals

Removing custom CSS that effects globally

Approach

I removed custom CSS that effects globally

Screenshots

No screenshots

Preview Link

https://yoshitharathnayake.github.io/sack-blog/

Checklist

  • This PR doesn't commit any keys, passwords, tokens, usernames, or other secrets.
  • I have read and understood the development best practices guidelines
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

Related PRs

Test environment

Learning

@Piumal1999
Copy link
Member

Good job @YoshithaRathnayake.

I think there's a lot of unused custom css in this repo because we have just used a copy of custom css in sack-site. Could you please remove those unwanted custom css as well with this pull request

@YoshithaRathnayake
Copy link
Member Author

Yeah sure but like what css want to remove @Piumal1999

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove custom CSS that effects globally
2 participants