fix issue with 12.48" rendering #336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
J-CMartin
reviewed
Apr 28, 2024
J-CMartin
reviewed
Apr 28, 2024
J-CMartin
reviewed
Apr 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #334 and #335 for more details.
In short, waveshare introduced a bug in the driver for the 12.48" display to add support for Raspberry Pi 5, but this caused non-Raspberry-Pi-5 rendering attempts with the 12.48" to fail. Furthermore, this PR will allow using the latest version of Raspberry Pi OS again and will hopefully also work with the latest kernel introduced in this version.
The changes boil down to the following:
Special thanks to @J-CMartin for finding the issue, performing the tests and providing useful information on how to fix this