Feature/agenda-module-aesthetic-changes

[emilyboda]

1. Moves the time and event titles further to the left, to allow more space for event titles.

• Events often have long titles that get cut off, especially if users increase font size

2. Right aligns the time

• I feel like it looks better aesthetically to have the end of the time and the beginning of the event be right next to each other.
• I also added a space before the dot to match the space after

3. Added "all day" to replace a missing time marker

• this may need to be translated, but I'm not sure how to do that. is there a better way to do it than just make a list of the words "all day" in every language? maybe the date module already has this built in?

Aesthetic changes look like this:
https://photos.app.goo.gl/Ti9gbmB6kwJw7Gj6A

[emilyboda]

apologies, i made the PR too early. still refining the code. will reopen later

[emilyboda]

Ok, updated the code

[aceisace]

I like the changes! It looks more compact while the text is well-readable. Thank you for your PR @emilyboda . Let's just wait a little until the tests have passed before attempting to merge

Just pulling your image here so it can be seen even if the link expires or goes down:

[aceisace]

Oh, the tests can't pass as the github secrets aren't configured in your repo. I'll manually run the unittests on my end with your changes

[aceisace]

I tested your changes locally and it seems there is a small issue with the time-width. The time-width needs some buffer for the width to show "all day". Currently, it will show only "all da":

Setting time-width to:

time_width = int(max([self.font.getlength(
                events['begin'].format(self.time_format, locale=self.language))
                for events in upcoming_events]) + 10)

notice the + 10 pixel buffer as this solves this issue:

The red boxes are the boxes generated by the write-function, this time with a red background to better understand the positions.

Please modify the time_width accordingly and then this can be merged 😁

[emilyboda]

Ok, I fixed it. Rather than adding the arbitrary 10, I added "all day" to the list of times that the program dynamically finds the max of. This should work for "all day" and also it will still work even if that string is changed to another language where the text is longer.

I also found one more unneeded buffer that I removed.

[aceisace]

I'm still getting the same issue, the y on the day is missing. For now, let's settle on the + 10. Later, this can be adjusted once a better version has been found

[emilyboda]

strange... Ok I added the +10

[emilyboda]

whoops... NOW i added the plus 10

[aceisace]

Looks good, thank you very much for your effort in creating this PR and making the agenda more compact, while ensuring readability of the text! Way to go @emilyboda ! Merging this now 👍