Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated requirements.txt #316

Closed
wants to merge 4 commits into from

Conversation

mrbwburns
Copy link
Contributor

@mrbwburns mrbwburns commented Jan 20, 2024

...based on pip freeze after pip install -r requirements.txt in a fresh venv

No feature added, just the inherent dependencies.

@mrbwburns
Copy link
Contributor Author

@aceisace I believe the test run config is broken, because the errors I got are not related to the requirements update:

FAILED tests/test_ical_parser.py::TestIcalendar::test_laod_from_file - ValueError: unknown url type: ''
FAILED tests/test_ical_parser.py::TestIcalendar::test_load_url - ValueError: unknown url type: ''
FAILED tests/test_inkycal_tindie.py::TestTindie::test_generate_image - AssertionError: Failed to get orders
FAILED tests/test_inkycal_weather.py::TestWeather::test_generate_image - AssertionError: Failure getting the current weather: code 401. Reason: {"cod":401, "message": "Invalid API key. Please see https://openweathermap.org/faq#error401 for more info."}
============ 4 failed, 18 passed, 20 warnings in 150.03s (0:02:30) =============
Error: Process completed with exit code 1.

@aceisace
Copy link
Member

Yes, you are right, I do know that some tests are currently failing and need some further investigation. But these aren't related to the PR. I'll take care of some of them shortly

@mrbwburns mrbwburns mentioned this pull request Jan 21, 2024
5 tasks
@mrbwburns
Copy link
Contributor Author

@aceisace do you want to wait for the tests to pass here or merge this without the checks?

@aceisace
Copy link
Member

aceisace commented Feb 8, 2024

merging #315 , hence this can be closed

@aceisace aceisace closed this Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants