Wallcalendar #298
Wallcalendar #298
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hi there and welcome to Inkycal. Thanks for opening this issue. As this is your first Pull-Request in this repository, please read through the contributing guidelines. Please note that non-critical pull-request cannot be merged into the main branch to ensure stability. Please create a new branch and ask to have it merged into main. Thanks for your understanding.
|
Thanks for creating this PR @howardgrigg . Let me know once this is ready for reviewing so I can integrate it 👍 |
|
@howardgrigg May I kindly ask you to use the default fonts already provided by Inkycal, namely NotoSans? The reason is that most fonts generally only support very few languages and attempting to show letters not supported by the font will result in tofus instead of the actual character, which may be confusing for users or even considered as a bug. The additional fonts can then be removed from this PR, but you may put a note in the module of your preferred font 👍 |
|
Yea sure, I've got a few edits as well that I've made over the past month - odd little bugs that have popped up, mainly around line length issues so I'll include those changes as well. Hopefully get to it in the next couple of days. |
|
Sure thing, thanks for the update! |
|
Marking this PR as stale due to inactivity |
|
@howardgrigg Is this something you will be updating? I'm very interested on a calendar with that format. It looks really good and it's what I'm looking for |
|
Marking this PR as stale due to inactivity |
|
Marking this PR as stale due to inactivity |
|
Marking this PR as stale due to inactivity |
First go at the WallCalendar module - needs review and documentation.
WallCalendar displays a grid of upcoming weeks and writes the event titles in each of the grid squares for each day.
Currently it doesn't work with other modules as the image is rotated 90 degrees for landscape orientation.