Impl banner component #41
Merged
+104
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wjeongchoi
approved these changes
Nov 21, 2024
|
이거 pr 이미지 업데이트 해주세요! |
|
이미지 업데이트를 까먹었네요! 추가해놓았습니다 |
wjeongchoi
approved these changes
Nov 25, 2024
Comment on lines
+97
to
+99
| <IndexWrapper> | ||
| {currentIndex + 1} / {images.length} | ||
| </IndexWrapper> |
There was a problem hiding this comment.
이거 typography에다가 style 추가한 걸로 수정해주세요!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
요약 *
It closes #40
일단 public 폴더에 temp로 사진 파일들 추가해서 구현했습니다. 추후에 onClick도 넣을 수 있게 했어요
양옆 화살표 버튼으로 이미지 넘길 수 있고 5초마다 자동으로 다음으로 넘어가게 구현되어 있습니다.
수정 - alt text를 커스텀으로 넣을 수 있고 현재 사진이 몇번째인지 아래에 보여요
스크린샷
수정 전 -
수정 후 -
이후 Task *