Skip to content

Commit

Permalink
feat: update nodejs and pnpm version
Browse files Browse the repository at this point in the history
  • Loading branch information
wjeongchoi committed Dec 26, 2024
1 parent 233a612 commit 7990933
Show file tree
Hide file tree
Showing 11 changed files with 8,706 additions and 6,958 deletions.
4 changes: 2 additions & 2 deletions .docker/dockerfile/api.Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,11 @@

# Base image with node + pnpm
# TODO: bump pnpm to 9 (must change 'engine' field in package.json)
FROM node:20-slim AS base
FROM node:22-slim AS base
ENV PNPM_HOME="/pnpm"
ENV PATH="$PNPM_HOME:$PATH"
RUN corepack enable
RUN corepack prepare pnpm@8.15.8 --activate
RUN corepack prepare pnpm@9.14.4 --activate
WORKDIR /app

# Build to output .next build directory
Expand Down
4 changes: 2 additions & 2 deletions .docker/dockerfile/web.Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,11 @@

# Base image with node + pnpm
# TODO: bump pnpm to 9 (must change 'engine' field in package.json)
FROM node:20-slim AS base
FROM node:22-slim AS base
ENV PNPM_HOME="/pnpm"
ENV PATH="$PNPM_HOME:$PATH"
RUN corepack enable
RUN corepack prepare pnpm@8.15.8 --activate
RUN corepack prepare pnpm@9.14.4 --activate
WORKDIR /app

# Build to output .next build directory
Expand Down
4 changes: 2 additions & 2 deletions .docker/dockerfile/web.bundle.Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,11 @@

# Base image with node + pnpm
# TODO: bump pnpm to 9 (must change 'engine' field in package.json)
FROM node:20-slim AS base
FROM node:22-slim AS base
ENV PNPM_HOME="/pnpm"
ENV PATH="$PNPM_HOME:$PATH"
RUN corepack enable
RUN corepack prepare pnpm@8.15.8 --activate
RUN corepack prepare pnpm@9.14.4 --activate
WORKDIR /app

# Build to output .next build directory
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/cd-demo.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ on:
jobs:
publish-docker-image:
name: "Build and Publish Latest Docker Image"
runs-on: ubuntu-latest
runs-on: ubuntu-24.04

strategy:
fail-fast: true
Expand Down Expand Up @@ -61,7 +61,7 @@ jobs:
deploy-production-image:
name: "Deploy Latest Staging Docker Image to Server"
needs: [publish-docker-image]
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
steps:
- name: "Image push via webhook"
uses: distributhor/workflow-webhook@v3
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/cd-stage.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ on:
jobs:
publish-docker-image:
name: "Build and Publish Latest Docker Image"
runs-on: ubuntu-latest
runs-on: ubuntu-24.04

strategy:
fail-fast: true
Expand Down Expand Up @@ -61,7 +61,7 @@ jobs:
deploy-production-image:
name: "Deploy Latest Staging Docker Image to Server"
needs: [publish-docker-image]
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
steps:
- name: "Image push via webhook"
uses: distributhor/workflow-webhook@v3
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,13 +12,13 @@ on:
jobs:
lint-and-format:
name: Lint and Format
runs-on: ubuntu-latest
runs-on: ubuntu-24.04

strategy:
matrix:
node-version: [20.x]
node-version: [22.12.0]
# See supported Node.js release schedule at https://nodejs.org/en/about/releases/
pnpm-version: [8.x]
pnpm-version: [9.14.4]

steps:
- uses: actions/checkout@v4
Expand Down
2 changes: 1 addition & 1 deletion .nvmrc
Original file line number Diff line number Diff line change
@@ -1 +1 @@
v20.9.0
v22.12.0
6 changes: 3 additions & 3 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -49,10 +49,10 @@
"typescript": "^5.1.6"
},
"engines": {
"node": "^20.9.0",
"pnpm": "^8.0.0"
"node": "^22.12.0",
"pnpm": "^9.14.4"
},
"packageManager": "pnpm@8.15.8",
"packageManager": "pnpm@9.14.4",
"dependencies": {
"uuid": "^11.0.3"
}
Expand Down
2 changes: 1 addition & 1 deletion packages/api/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -82,5 +82,5 @@
"coverageDirectory": "../coverage",
"testEnvironment": "node"
},
"packageManager": "pnpm@8.15.8"
"packageManager": "pnpm@9.14.4"
}
2 changes: 1 addition & 1 deletion packages/web/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -61,5 +61,5 @@
"storybook": "^8.3.6",
"typescript": "^5"
},
"packageManager": "pnpm@8.15.8"
"packageManager": "pnpm@9.14.4"
}
Loading

0 comments on commit 7990933

Please sign in to comment.