Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create storybook for TextInput, Card, Modal #1245
base: dev
Are you sure you want to change the base?
Create storybook for TextInput, Card, Modal #1245
Changes from 2 commits
016c911
f26a734
b06990f
09ea9cc
d33e0d3
a4e4baf
747b842
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
요거 스토리북 Primary 말고 하나 더 추가되면 좋을 거 같다!
PlayGround..? 이름 뭐라 해야 할지 모르겠는데 버튼 클릭하면 모달 열리고 확인 혹은 취소 누르면 모달 사라지는? 그런 동적인걸 확인 할 수 있게 하나 더 있으면 좋을거 같아!
그리고 CancellableModal 말고 ConfirmModal, ErrorModal, AgreeModal 도 있으면 좋을거 같오
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
시간 되면 예전에 프론트 문서에 요렇게 적었었는데 onClose 관련된 부분도 어디 설명이 되어 있으면 좋을 것 같아
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.