Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NOISSUE - Move SMPP notifier to Magistrala core #26

Merged
merged 1 commit into from
Dec 31, 2024

Conversation

dborovcanin
Copy link
Contributor

What type of PR is this?

This is a refactor.

What does this do?

This moves SMPP notifier to the Magistrala core.

Which issue(s) does this PR fix/relate to?

There is no such issue.

Have you included tests for your changes?

No.

Did you document any new/modified feature?

No.

Notes

N/A

Copy link

codecov bot commented Dec 31, 2024

Codecov Report

Attention: Patch coverage is 0% with 35 lines in your changes missing coverage. Please review.

Project coverage is 50.07%. Comparing base (14282fb) to head (8e64ac5).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
consumers/notifiers/smpp/notifier.go 0.00% 35 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #26      +/-   ##
==========================================
+ Coverage   40.67%   50.07%   +9.39%     
==========================================
  Files          68       24      -44     
  Lines        6416     1264    -5152     
==========================================
- Hits         2610      633    -1977     
+ Misses       3520      557    -2963     
+ Partials      286       74     -212     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dborovcanin dborovcanin merged commit 3ee7b13 into absmach:main Dec 31, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant