Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed Reports to be Offline #533

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

PensiveHike
Copy link
Contributor

Removed mention of accessing CSS files from the internet within the html report as this would cause a delay in loading times.
I originally, created an option for a user to choose the output to be online or offline, but from advice given by @Johann-PLW, I made it offline by default with no option for online version.
Additionally, I copied code from iLEAPP that places files needed for the final report to be in the _elements folder as this tidies the ALEAPP folder, and now only the elements folder is copied to final report folder as opposed to several individual files.

@PensiveHike
Copy link
Contributor Author

I don't really know how Git works, but after generating the previous pull request, I have added additional features. It would appear these new features have been added to the previous pull request, rather than the need to create a new request. The changes for the new features are as follows:

Identified new way to decode encoded strings found within com.sec.android.app.myfiles OperationHistory.db and com.sec.android.gallery3d local.db. These provide greater insight into user interactions. Have implemented this decoding within script titled gallery3DLog.py and have updated smyfilesOpHistory.
Added another entry to decode dictionary within smyfilesOpHistory.
Added icon_mappings for the MyFiles scripts where there were none.
Updated galleryTrash to use latest version of artefacts introduction. Added this to Gallery3D category, so now shows alongside records for Gallery3D Log results.

@Johann-PLW
Copy link
Collaborator

Hi @PensiveHike ,
I did not push your PR as there is a bug with the ascending/descending symbol in the column headers.
image

@PensiveHike
Copy link
Contributor Author

PensiveHike commented Dec 27, 2024

As I mentioned previously, I am not familiar with Github. Making changes, then reversing these and then doing further work made the chain messy. Therefore, I cloned Brig's ALEAPP repository again and made the changes on this fresh copy. I have tried to overwrite my repository with this cleaner version and it appears to have worked, but perhaps you can check this?

I found the filter function wasn't working due to css links, so this has been amended.
If the above hasn't worked very well, I can generate a new pull request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants