Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Update outdated dependencies #469

Closed
wants to merge 2 commits into from
Closed

WIP: Update outdated dependencies #469

wants to merge 2 commits into from

Conversation

funkyboy
Copy link
Contributor

Fix #467

paddybyers
paddybyers approved these changes Feb 19, 2018
View reviewed changes
Copy link
Member

@paddybyers paddybyers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@funkyboy
Copy link
Contributor Author

@paddybyers Not so fast. Travis has a different opinion :( https://travis-ci.org/ably/ably-js/jobs/343498093

@funkyboy funkyboy changed the title Update outdated dependencies WIP: Update outdated dependencies Feb 20, 2018
@funkyboy
Copy link
Contributor Author

Travis issue will be fixed when this is merged.
Should happen soon.

SimonWoolf
SimonWoolf approved these changes Feb 20, 2018
View reviewed changes
Copy link
Member

@SimonWoolf SimonWoolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Note: we should make sure we document well that we don't support node <4.x per #457 before publishing this.

@SimonWoolf
Copy link
Member

Merged as b22aef8 (cherry-picked and manually regen'd package-lock.json due to pr conflicts)

@SimonWoolf SimonWoolf closed this Feb 20, 2018
@SimonWoolf SimonWoolf deleted the update-outdated-dependencies branch February 20, 2018 09:42
@SimonWoolf SimonWoolf mentioned this pull request Feb 20, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SimonWoolf SimonWoolf SimonWoolf approved these changes

@paddybyers paddybyers paddybyers approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@funkyboy @SimonWoolf @paddybyers